Emit actor hop as part of call to the getter.#59927
Merged
DougGregor merged 1 commit intoswiftlang:release/5.7from Jul 7, 2022
Merged
Emit actor hop as part of call to the getter.#59927DougGregor merged 1 commit intoswiftlang:release/5.7from
DougGregor merged 1 commit intoswiftlang:release/5.7from
Conversation
When emitting a call to the getter for storage, emit the actor hop (and hop back) as part of the call itself, rather than around the whole initialization. This address a bug involving initialization with an optional binding in an `if let`, where the hop-back would only be performed on the non-nil branch. Fixes rdar://96487805 / FB10562197
Member
Author
|
@swift-ci please test |
hborla
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emitting a call to the getter for storage, emit the actor hop (and
hop back) as part of the call itself, rather than around the whole
initialization. This address a bug involving initialization with an
optional binding in an
if let, where the hop-back would only beperformed on the non-nil branch.
Fixes rdar://96487805 / FB10562197