Skip to content

[ConstraintSystem] Prefer overloads choices that are variables over unapplied functions using the solver score.#39390

Merged
hborla merged 2 commits intoswiftlang:mainfrom
hborla:prefer-variables-to-unapplied-functions
Sep 24, 2021
Merged

[ConstraintSystem] Prefer overloads choices that are variables over unapplied functions using the solver score.#39390
hborla merged 2 commits intoswiftlang:mainfrom
hborla:prefer-variables-to-unapplied-functions

Conversation

@hborla
Copy link
Copy Markdown
Member

@hborla hborla commented Sep 22, 2021

This change increases the score when the solver attempts an overload choice that is an unapplied reference to a function declaration. This will allows the solver to prune those overload choices when it has already found a solution with a property (all else equal in the score). This is already done as an ambiguity tie-breaker in solution ranking, but adding this bit to the score will prune a lot of search space within the solver.

This should fix many of the type checker performance issues that were observed with the addition of count(where:), including using array.count in operator expressions.

Resolves: rdar://47742750

hborla
hborla commented Sep 22, 2021
View reviewed changes
validation-test/Sema/type_checker_perf/fast/property_vs_unapplied_func.swift Outdated
Copy link
Copy Markdown
Member Author

@hborla hborla Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anybody knows of other count(where:) test cases, please let me know and I'll add them to this file!

@hborla
[ConstraintSystem] Increase the score when attempting overload choices
1737303 
for unapplied references when the choice is a function declaration.

This will allow the solver to prune those overload choices when it
has already found a solultion with a property (all else equal in the
score). This is already done as an ambiguity tie-breaker in solution
ranking, but adding this bit to the score will prune a lot of search
space within the solver.
@hborla
[Test] Add type checker performance tests using description(with:) and
2032da0 
count(where:).
@hborla hborla force-pushed the prefer-variables-to-unapplied-functions branch from 0a0f91a to 2032da0 Compare September 22, 2021 20:33
@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 22, 2021

@swift-ci please test source compatibility

@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 22, 2021

@swift-ci please smoke test compiler performance

@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 22, 2021

@swift-ci please test compiler performance

@hborla hborla requested a review from xedin September 22, 2021 20:45
@hborla hborla marked this pull request as ready for review September 22, 2021 23:16
@swift-ci
Copy link
Copy Markdown
Contributor

swift-ci commented Sep 23, 2021

Summary for main smoketest

Regressions found (see below)

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 273,664,778,707 273,515,454,228 -149,324,479 -0.05%
LLVM.NumLLVMBytesOutput 9,583,752 9,583,752 0 0.0%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 33,263 31,144 -2,119 -6.37% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (255)
name old new delta delta_pct
AST.ImportSetCacheHit 14,796 14,796 0 0.0%
AST.ImportSetCacheMiss 2,185 2,185 0 0.0%
AST.ImportSetFoldHit 690 690 0 0.0%
AST.ImportSetFoldMiss 1,495 1,495 0 0.0%
AST.ModuleShadowCacheHit 0 0 0 0.0%
AST.ModuleShadowCacheMiss 0 0 0 0.0%
AST.ModuleVisibilityCacheHit 4 4 0 0.0%
AST.ModuleVisibilityCacheMiss 4 4 0 0.0%
AST.NumASTBytesAllocated 197,012,110 197,008,866 -3,244 -0.0%
AST.NumASTScopeExpansions 32,078 32,078 0 0.0%
AST.NumASTScopeLookups 30,702 30,702 0 0.0%
AST.NumDecls 896 896 0 0.0%
AST.NumDependencies 1,776 1,776 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 1,325 1,325 0 0.0%
AST.NumLocalTypeDecls 0 0 0 0.0%
AST.NumModuleLookupClassMember 0 0 0 0.0%
AST.NumModuleLookupValue 517,918 517,918 0 0.0%
AST.NumObjCMethods 68 68 0 0.0%
AST.NumOperators 0 0 0 0.0%
AST.NumPrecedenceGroups 0 0 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 36,966 36,966 0 0.0%
AST.NumReferencedTopLevelNames 3,538 3,538 0 0.0%
AST.NumSourceBuffers 1,550 1,550 0 0.0%
AST.NumSourceLines 43,000 43,000 0 0.0%
AST.NumTotalClangImportedEntities 9,174 9,174 0 0.0%
Frontend.MaxMallocUsage 3,802,308,872 3,795,824,624 -6,484,248 -0.17%
Frontend.NumInstructionsExecuted 273,664,778,707 273,515,454,228 -149,324,479 -0.05%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 62 62 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 1,161 1,161 0 0.0%
IRModule.NumIRAliases 1,616 1,616 0 0.0%
IRModule.NumIRBasicBlocks 33,537 33,537 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 14,781 14,781 0 0.0%
IRModule.NumIRGlobals 22,863 22,863 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 355,570 355,570 0 0.0%
IRModule.NumIRNamedMetaData 307 307 0 0.0%
IRModule.NumIRValueSymbols 34,415 34,415 0 0.0%
LLVM.NumLLVMBytesOutput 9,583,752 9,583,752 0 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 1,400 1,400 0 0.0%
Parse.NumIterableDeclContextParsed 3,888 3,888 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 2,276 2,276 0 0.0%
Parse.ParseMembersRequest 3,246 3,246 0 0.0%
Parse.ParseSourceFileRequest 1,550 1,550 0 0.0%
SILGen.ASTLoweringRequest 64 64 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 11,754 11,754 0 0.0%
SILModule.NumSILGenGlobalVariables 344 344 0 0.0%
SILModule.NumSILGenVtables 160 160 0 0.0%
SILModule.NumSILGenWitnessTables 602 602 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 13,292 13,292 0 0.0%
SILModule.NumSILOptGlobalVariables 358 358 0 0.0%
SILModule.NumSILOptVtables 160 160 0 0.0%
SILModule.NumSILOptWitnessTables 776 776 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 252 252 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 966 966 0 0.0%
Sema.AbstractGenericSignatureRequest 224 224 0 0.0%
Sema.AccessLevelRequest 15,578 15,578 0 0.0%
Sema.ActorIsolationRequest 22,301 22,301 0 0.0%
Sema.AllMembersRequest 456 456 0 0.0%
Sema.AnyObjectLookupRequest 0 0 0 0.0%
Sema.ApplyAccessNoteRequest 17,934 17,934 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 84 84 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 124 124 0 0.0%
Sema.AttachedPropertyWrappersRequest 9,706 9,706 0 0.0%
Sema.AttachedResultBuilderRequest 4,490 4,490 0 0.0%
Sema.BodyInitKindRequest 210 210 0 0.0%
Sema.CallerSideDefaultArgExprRequest 256 256 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 50 50 0 0.0%
Sema.CheckRedeclarationRequest 8,644 8,644 0 0.0%
Sema.ClassAncestryFlagsRequest 878 878 0 0.0%
Sema.ClosureHasExplicitResultRequest 480 480 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CompareDeclSpecializationRequest 3,076 3,048 -28 -0.91%
Sema.ConditionalRequirementsRequest 2,714 2,714 0 0.0%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 606 606 0 0.0%
Sema.DefaultArgumentExprRequest 912 912 0 0.0%
Sema.DefaultArgumentInitContextRequest 4 4 0 0.0%
Sema.DefaultDefinitionTypeRequest 50 50 0 0.0%
Sema.DefaultTypeRequest 2,286 2,286 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 147,743 147,743 0 0.0%
Sema.DirectOperatorLookupRequest 4,887 4,887 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 2,837 2,837 0 0.0%
Sema.DistributedModuleIsAvailableRequest 0 0 0 0.0%
Sema.DynamicallyReplacedDeclRequest 8,184 8,184 0 0.0%
Sema.EnumRawTypeRequest 204 204 0 0.0%
Sema.EnumRawValuesRequest 126 126 0 0.0%
Sema.ExistentialConformsToSelfRequest 122 122 0 0.0%
Sema.ExtendedNominalRequest 5,650 5,650 0 0.0%
Sema.ExtendedTypeRequest 524 524 0 0.0%
Sema.FragileFunctionKindRequest 11,786 11,786 0 0.0%
Sema.FunctionOperatorRequest 8 8 0 0.0%
Sema.GenericParamListRequest 23,586 23,586 0 0.0%
Sema.GenericSignatureRequest 14,700 14,700 0 0.0%
Sema.GetDestructorRequest 198 198 0 0.0%
Sema.GetDistributedRemoteFuncRequest 0 0 0 0.0%
Sema.GetImplicitSendableRequest 470 470 0 0.0%
Sema.GlobalActorAttributeRequest 25,191 25,191 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 86 86 0 0.0%
Sema.HasCircularRawValueRequest 120 120 0 0.0%
Sema.HasDefaultInitRequest 320 320 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 2,568 2,568 0 0.0%
Sema.HasImplementationOnlyImportsRequest 1,550 1,550 0 0.0%
Sema.HasIsolatedSelfRequest 46,999 46,999 0 0.0%
Sema.HasMemberwiseInitRequest 108 108 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 140 140 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 320 320 0 0.0%
Sema.InferredGenericSignatureRequest 406 406 0 0.0%
Sema.InheritedDeclsReferencedRequest 21,194 21,194 0 0.0%
Sema.InheritedProtocolsRequest 3,274 3,274 0 0.0%
Sema.InheritedTypeRequest 720 720 0 0.0%
Sema.InheritsSuperclassInitializersRequest 124 124 0 0.0%
Sema.InitKindRequest 496 496 0 0.0%
Sema.InterfaceTypeRequest 49,134 49,134 0 0.0%
Sema.IsABICompatibleOverrideRequest 1,592 1,592 0 0.0%
Sema.IsAccessorTransparentRequest 2,598 2,598 0 0.0%
Sema.IsActorRequest 9,398 9,398 0 0.0%
Sema.IsCallableNominalTypeRequest 20 20 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 118 118 0 0.0%
Sema.IsDefaultActorRequest 288 288 0 0.0%
Sema.IsDistributedActorRequest 9,178 9,178 0 0.0%
Sema.IsDynamicRequest 12,196 12,196 0 0.0%
Sema.IsFinalRequest 13,520 13,520 0 0.0%
Sema.IsGetterMutatingRequest 2,896 2,896 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 17,538 17,538 0 0.0%
Sema.IsObjCRequest 11,972 11,972 0 0.0%
Sema.IsSetterMutatingRequest 2,472 2,472 0 0.0%
Sema.IsStaticRequest 6,670 6,670 0 0.0%
Sema.LazyStoragePropertyRequest 16 16 0 0.0%
Sema.LookupAllConformancesInContextRequest 1,672 1,672 0 0.0%
Sema.LookupConformanceInModuleRequest 106,539 106,487 -52 -0.05%
Sema.LookupInModuleRequest 37,393 37,393 0 0.0%
Sema.LookupInfixOperatorRequest 142 142 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 90 90 0 0.0%
Sema.LookupPrefixOperatorRequest 0 0 0 0.0%
Sema.MangleLocalTypeDeclRequest 0 0 0 0.0%
Sema.ModuleImplicitImportsRequest 50 50 0 0.0%
Sema.ModuleLibraryLevelRequest 0 0 0 0.0%
Sema.ModuleQualifiedLookupRequest 11,679 11,679 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 109,806 109,806 0 0.0%
Sema.NamingPatternRequest 1,062 1,062 0 0.0%
Sema.NeedsNewVTableEntryRequest 5,448 5,448 0 0.0%
Sema.NumAccessorBodiesSynthesized 1,810 1,810 0 0.0%
Sema.NumAccessorsSynthesized 2,220 2,220 0 0.0%
Sema.NumConformanceAccessPathsRecorded 1,990 1,990 0 0.0%
Sema.NumConformancesDeserialized 25,832 25,832 0 0.0%
Sema.NumConstraintScopes 54,929 54,858 -71 -0.13%
Sema.NumConstraintsConsideredForEdgeContraction 820 820 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 246,316 246,316 0 0.0%
Sema.NumDeclsTypechecked 11,958 11,958 0 0.0%
Sema.NumGenericSignatureBuilders 3,868 3,868 0 0.0%
Sema.NumLazyIterableDeclContexts 44,846 44,846 0 0.0%
Sema.NumLazyRequirementSignatures 4,506 4,506 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 3,088 3,088 0 0.0%
Sema.NumLeafScopes 39,891 39,872 -19 -0.05%
Sema.NumRedundantRequirementSteps 892 892 0 0.0%
Sema.NumRequirementMachineCompletionSteps 0 0 0 0.0%
Sema.NumRequirementMachineUnifiedConcreteTerms 0 0 0 0.0%
Sema.NumRequirementMachines 0 0 0 0.0%
Sema.NumTypesDeserialized 81,859 81,859 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 38,355 38,355 0 0.0%
Sema.OpaqueReadOwnershipRequest 2,466 2,466 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 0 0 0 0.0%
Sema.OverriddenDeclsRequest 17,580 17,580 0 0.0%
Sema.ParamSpecifierRequest 12,318 12,318 0 0.0%
Sema.PatternBindingEntryRequest 2,922 2,922 0 0.0%
Sema.PatternTypeRequest 3,354 3,354 0 0.0%
Sema.PolymorphicEffectKindRequest 596 596 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 50 50 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 2,348 2,348 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 124 124 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 2,362 2,362 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 2,864 2,864 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 266 266 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 36,238 36,238 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RenamedDeclRequest 0 0 0 0.0%
Sema.RequirementRequest 282 282 0 0.0%
Sema.RequirementSignatureRequest 3,316 3,316 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 7,916 7,916 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 2,464 2,464 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 2,048 2,048 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 17,150 17,150 0 0.0%
Sema.ResultBuilderTypeRequest 2,182 2,182 0 0.0%
Sema.ResultTypeRequest 5,296 5,296 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 28,169 28,169 0 0.0%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 4,708 4,708 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 8,838 8,838 0 0.0%
Sema.SetterAccessLevelRequest 826 826 0 0.0%
Sema.SimpleDidSetRequest 3,476 3,476 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 16 16 0 0.0%
Sema.StorageImplInfoRequest 8,954 8,954 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 284 284 0 0.0%
Sema.StoredPropertiesRequest 1,935 1,935 0 0.0%
Sema.StructuralTypeRequest 0 0 0 0.0%
Sema.SuperclassDeclRequest 2,548 2,548 0 0.0%
Sema.SuperclassTypeRequest 328 328 0 0.0%
Sema.SynthesizeAccessorRequest 2,220 2,220 0 0.0%
Sema.SynthesizeDefaultInitRequest 26 26 0 0.0%
Sema.SynthesizeMainFunctionRequest 950 950 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 24 24 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 3,672 3,672 0 0.0%
Sema.TypeCheckSourceFileRequest 124 124 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 144 144 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 26 26 0 0.0%
Sema.USRGenerationRequest 4,158 4,158 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 740 740 0 0.0%
Sema.UnderlyingTypeRequest 104 104 0 0.0%
Sema.UnqualifiedLookupRequest 27,164 27,164 0 0.0%
Sema.ValidatePrecedenceGroupRequest 662 662 0 0.0%
Sema.ValueWitnessRequest 362 362 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 62 62 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 346,773,119,600 346,701,657,519 -71,462,081 -0.02%
LLVM.NumLLVMBytesOutput 10,296,568 10,296,408 -160 -0.0%

release detailed

Regressed (1)
name old new delta delta_pct
Frontend.MaxMallocUsage 1,106,099,920 1,144,864,376 38,764,456 3.5% ⛔
Improved (1)
name old new delta delta_pct
Sema.CompareDeclSpecializationRequest 2,300 2,272 -28 -1.22% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (254)
name old new delta delta_pct
AST.ImportSetCacheHit 6,578 6,578 0 0.0%
AST.ImportSetCacheMiss 155 155 0 0.0%
AST.ImportSetFoldHit 80 80 0 0.0%
AST.ImportSetFoldMiss 75 75 0 0.0%
AST.ModuleShadowCacheHit 0 0 0 0.0%
AST.ModuleShadowCacheMiss 0 0 0 0.0%
AST.ModuleVisibilityCacheHit 2 2 0 0.0%
AST.ModuleVisibilityCacheMiss 2 2 0 0.0%
AST.NumASTBytesAllocated 34,858,950 34,858,414 -536 -0.0%
AST.NumASTScopeExpansions 13,540 13,540 0 0.0%
AST.NumASTScopeLookups 18,044 18,044 0 0.0%
AST.NumDecls 448 448 0 0.0%
AST.NumDependencies 72 72 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 51 51 0 0.0%
AST.NumLocalTypeDecls 0 0 0 0.0%
AST.NumModuleLookupClassMember 0 0 0 0.0%
AST.NumModuleLookupValue 202,389 202,389 0 0.0%
AST.NumObjCMethods 34 34 0 0.0%
AST.NumOperators 0 0 0 0.0%
AST.NumPrecedenceGroups 0 0 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 0 0 0 0.0%
AST.NumReferencedTopLevelNames 0 0 0 0.0%
AST.NumSourceBuffers 62 62 0 0.0%
AST.NumSourceLines 21,500 21,500 0 0.0%
AST.NumSourceLinesPerSecond 420 423 3 0.71%
AST.NumTotalClangImportedEntities 2,070 2,070 0 0.0%
Frontend.NumInstructionsExecuted 346,773,119,600 346,701,657,519 -71,462,081 -0.02%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 0 0 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 1,163 1,163 0 0.0%
IRModule.NumIRAliases 1,418 1,418 0 0.0%
IRModule.NumIRBasicBlocks 26,358 26,358 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 12,414 12,414 0 0.0%
IRModule.NumIRGlobals 19,706 19,706 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 260,546 260,546 0 0.0%
IRModule.NumIRNamedMetaData 305 305 0 0.0%
IRModule.NumIRValueSymbols 31,829 31,829 0 0.0%
LLVM.NumLLVMBytesOutput 10,296,568 10,296,408 -160 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 1,400 1,400 0 0.0%
Parse.NumIterableDeclContextParsed 454 454 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 1,156 1,156 0 0.0%
Parse.ParseMembersRequest 2 2 0 0.0%
Parse.ParseSourceFileRequest 62 62 0 0.0%
SILGen.ASTLoweringRequest 2 2 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 6,018 6,018 0 0.0%
SILModule.NumSILGenGlobalVariables 178 178 0 0.0%
SILModule.NumSILGenVtables 80 80 0 0.0%
SILModule.NumSILGenWitnessTables 318 318 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 4,884 4,884 0 0.0%
SILModule.NumSILOptGlobalVariables 188 188 0 0.0%
SILModule.NumSILOptVtables 86 86 0 0.0%
SILModule.NumSILOptWitnessTables 340 340 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 8 8 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 464 464 0 0.0%
Sema.AbstractGenericSignatureRequest 136 136 0 0.0%
Sema.AccessLevelRequest 7,888 7,888 0 0.0%
Sema.ActorIsolationRequest 7,590 7,590 0 0.0%
Sema.AllMembersRequest 456 456 0 0.0%
Sema.AnyObjectLookupRequest 0 0 0 0.0%
Sema.ApplyAccessNoteRequest 8,092 8,092 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 30 30 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 62 62 0 0.0%
Sema.AttachedPropertyWrappersRequest 4,430 4,430 0 0.0%
Sema.AttachedResultBuilderRequest 2,514 2,514 0 0.0%
Sema.BodyInitKindRequest 176 176 0 0.0%
Sema.CallerSideDefaultArgExprRequest 240 240 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 2 2 0 0.0%
Sema.CheckRedeclarationRequest 4,662 4,662 0 0.0%
Sema.ClassAncestryFlagsRequest 242 242 0 0.0%
Sema.ClosureHasExplicitResultRequest 456 456 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.ConditionalRequirementsRequest 846 846 0 0.0%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 208 208 0 0.0%
Sema.DefaultArgumentExprRequest 456 456 0 0.0%
Sema.DefaultArgumentInitContextRequest 0 0 0 0.0%
Sema.DefaultDefinitionTypeRequest 14 14 0 0.0%
Sema.DefaultTypeRequest 1,836 1,836 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 108,742 108,733 -9 -0.01%
Sema.DirectOperatorLookupRequest 4,104 4,104 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 2,564 2,564 0 0.0%
Sema.DistributedModuleIsAvailableRequest 0 0 0 0.0%
Sema.DynamicallyReplacedDeclRequest 3,798 3,798 0 0.0%
Sema.EnumRawTypeRequest 60 60 0 0.0%
Sema.EnumRawValuesRequest 66 66 0 0.0%
Sema.ExistentialConformsToSelfRequest 22 22 0 0.0%
Sema.ExtendedNominalRequest 226 226 0 0.0%
Sema.ExtendedTypeRequest 226 226 0 0.0%
Sema.FragileFunctionKindRequest 5,262 5,262 0 0.0%
Sema.FunctionOperatorRequest 4 4 0 0.0%
Sema.GenericParamListRequest 5,773 5,773 0 0.0%
Sema.GenericSignatureRequest 4,715 4,715 0 0.0%
Sema.GetDestructorRequest 92 92 0 0.0%
Sema.GetDistributedRemoteFuncRequest 0 0 0 0.0%
Sema.GetImplicitSendableRequest 220 220 0 0.0%
Sema.GlobalActorAttributeRequest 8,724 8,724 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 42 42 0 0.0%
Sema.HasCircularRawValueRequest 60 60 0 0.0%
Sema.HasDefaultInitRequest 128 128 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 748 748 0 0.0%
Sema.HasImplementationOnlyImportsRequest 62 62 0 0.0%
Sema.HasIsolatedSelfRequest 17,174 17,174 0 0.0%
Sema.HasMemberwiseInitRequest 48 48 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 84 84 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 128 128 0 0.0%
Sema.InferredGenericSignatureRequest 140 140 0 0.0%
Sema.InheritedDeclsReferencedRequest 4,036 4,036 0 0.0%
Sema.InheritedProtocolsRequest 266 266 0 0.0%
Sema.InheritedTypeRequest 306 306 0 0.0%
Sema.InheritsSuperclassInitializersRequest 40 40 0 0.0%
Sema.InitKindRequest 204 204 0 0.0%
Sema.InterfaceTypeRequest 15,867 15,867 0 0.0%
Sema.IsABICompatibleOverrideRequest 772 772 0 0.0%
Sema.IsAccessorTransparentRequest 1,254 1,254 0 0.0%
Sema.IsActorRequest 1,032 1,032 0 0.0%
Sema.IsCallableNominalTypeRequest 20 20 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 76 76 0 0.0%
Sema.IsDefaultActorRequest 108 108 0 0.0%
Sema.IsDistributedActorRequest 1,006 1,006 0 0.0%
Sema.IsDynamicRequest 5,916 5,916 0 0.0%
Sema.IsFinalRequest 4,930 4,930 0 0.0%
Sema.IsGetterMutatingRequest 1,506 1,506 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 10,064 10,064 0 0.0%
Sema.IsObjCRequest 5,130 5,130 0 0.0%
Sema.IsSetterMutatingRequest 1,408 1,408 0 0.0%
Sema.IsStaticRequest 2,988 2,988 0 0.0%
Sema.LazyStoragePropertyRequest 4 4 0 0.0%
Sema.LookupAllConformancesInContextRequest 610 610 0 0.0%
Sema.LookupConformanceInModuleRequest 104,287 104,263 -24 -0.02%
Sema.LookupInModuleRequest 10,379 10,379 0 0.0%
Sema.LookupInfixOperatorRequest 132 132 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 84 84 0 0.0%
Sema.LookupPrefixOperatorRequest 0 0 0 0.0%
Sema.MangleLocalTypeDeclRequest 0 0 0 0.0%
Sema.ModuleImplicitImportsRequest 2 2 0 0.0%
Sema.ModuleLibraryLevelRequest 0 0 0 0.0%
Sema.ModuleQualifiedLookupRequest 1,495 1,495 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 34,822 34,822 0 0.0%
Sema.NamingPatternRequest 354 354 0 0.0%
Sema.NeedsNewVTableEntryRequest 2,734 2,734 0 0.0%
Sema.NumAccessorBodiesSynthesized 906 906 0 0.0%
Sema.NumAccessorsSynthesized 914 914 0 0.0%
Sema.NumConformanceAccessPathsRecorded 2,228 2,228 0 0.0%
Sema.NumConformancesDeserialized 13,728 13,728 0 0.0%
Sema.NumConstraintScopes 48,085 48,014 -71 -0.15%
Sema.NumConstraintsConsideredForEdgeContraction 816 816 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 33,021 33,021 0 0.0%
Sema.NumDeclsTypechecked 6,548 6,548 0 0.0%
Sema.NumGenericSignatureBuilders 816 816 0 0.0%
Sema.NumLazyIterableDeclContexts 4,206 4,206 0 0.0%
Sema.NumLazyRequirementSignatures 254 254 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 212 212 0 0.0%
Sema.NumLeafScopes 35,101 35,082 -19 -0.05%
Sema.NumRedundantRequirementSteps 360 360 0 0.0%
Sema.NumRequirementMachineCompletionSteps 0 0 0 0.0%
Sema.NumRequirementMachineUnifiedConcreteTerms 0 0 0 0.0%
Sema.NumRequirementMachines 0 0 0 0.0%
Sema.NumTypesDeserialized 17,056 17,056 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 2,798 2,798 0 0.0%
Sema.OpaqueReadOwnershipRequest 982 982 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 0 0 0 0.0%
Sema.OverriddenDeclsRequest 5,697 5,697 0 0.0%
Sema.ParamSpecifierRequest 5,018 5,018 0 0.0%
Sema.PatternBindingEntryRequest 1,356 1,356 0 0.0%
Sema.PatternTypeRequest 1,782 1,782 0 0.0%
Sema.PolymorphicEffectKindRequest 374 374 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 2 2 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 1,388 1,388 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 62 62 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 1,412 1,412 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 1,498 1,498 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 52 52 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 19,328 19,328 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RenamedDeclRequest 0 0 0 0.0%
Sema.RequirementRequest 132 132 0 0.0%
Sema.RequirementSignatureRequest 268 268 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 6,046 6,046 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 938 938 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 1,284 1,284 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 6,626 6,626 0 0.0%
Sema.ResultBuilderTypeRequest 1,988 1,988 0 0.0%
Sema.ResultTypeRequest 2,126 2,126 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 8,243 8,243 0 0.0%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 1,918 1,918 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 1,944 1,944 0 0.0%
Sema.SetterAccessLevelRequest 534 534 0 0.0%
Sema.SimpleDidSetRequest 1,682 1,682 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 6 6 0 0.0%
Sema.StorageImplInfoRequest 6,490 6,490 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 178 178 0 0.0%
Sema.StoredPropertiesRequest 566 566 0 0.0%
Sema.StructuralTypeRequest 0 0 0 0.0%
Sema.SuperclassDeclRequest 312 312 0 0.0%
Sema.SuperclassTypeRequest 128 128 0 0.0%
Sema.SynthesizeAccessorRequest 914 914 0 0.0%
Sema.SynthesizeDefaultInitRequest 12 12 0 0.0%
Sema.SynthesizeMainFunctionRequest 456 456 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 12 12 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 2,562 2,562 0 0.0%
Sema.TypeCheckSourceFileRequest 62 62 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 56 56 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 6 6 0 0.0%
Sema.USRGenerationRequest 2,080 2,080 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 142 142 0 0.0%
Sema.UnderlyingTypeRequest 24 24 0 0.0%
Sema.UnqualifiedLookupRequest 9,366 9,366 0 0.0%
Sema.ValidatePrecedenceGroupRequest 642 642 0 0.0%
Sema.ValueWitnessRequest 220 220 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 2 2 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@swift-ci

This comment has been minimized.

Sign in to view
@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 23, 2021

Source compatibility failures are unrelated (and also failing on main)

@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 23, 2021

@swift-ci please smoke test

@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 23, 2021

@swift-ci please test Windows platform

1 similar comment
@hborla
Copy link
Copy Markdown
Member Author

hborla commented Sep 23, 2021

@swift-ci please test Windows platform

@hborla hborla merged commit a215cda into swiftlang:main Sep 24, 2021
@hborla hborla deleted the prefer-variables-to-unapplied-functions branch September 24, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xedin xedin xedin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hborla @swift-ci @xedin