Skip to content

Rename Process to CommandLine#3598

Merged
parkera merged 2 commits intoswiftlang:masterfrom
parkera:se86_rename_process
Jul 19, 2016
Merged

Rename Process to CommandLine#3598
parkera merged 2 commits intoswiftlang:masterfrom
parkera:se86_rename_process

Conversation

@parkera
Copy link
Contributor

@parkera parkera commented Jul 19, 2016

What's in this pull request?

As part of SE-0086, we decided to rename the NSTask class to Process. This PR changes Swift.Process to Swift.CommandLine to make that possible.

Resolved bug number

Part of SE-0086
rdar://27415229


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

Rename Process to CommandLine [SE-0086].
@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

swiftpm PR coming soon.

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

@swift-ci please test

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

This will fail without the swiftpm PR, but we can verify the rest.

@rintaro
Copy link
Member

rintaro commented Jul 19, 2016

I guess adding migration aid can be harmful in this case

@available(*, unavailable, renamed: "CommandLine")
typealias Process = CommandLine

Is there any way to automated migration?

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

I'm going to add a temporary typealias (for a day or two), but once we rename NSTask to Process, we can't have an unavailable attribute on it.

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

@swift-ci Please test and merge

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

We're going to go ahead and merge this.

@parkera parkera merged commit fe93266 into swiftlang:master Jul 19, 2016
@parkera parkera mentioned this pull request Jul 21, 2016
1 task
@parkera parkera deleted the se86_rename_process branch July 24, 2016 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants