Update GYB Files for SwiftSyntax Double and Int Convenience Properties#33948
Merged
akyrtzi merged 1 commit intoswiftlang:masterfrom Sep 19, 2020
vermont42:literal-values
Merged
Update GYB Files for SwiftSyntax Double and Int Convenience Properties#33948akyrtzi merged 1 commit intoswiftlang:masterfrom vermont42:literal-values
akyrtzi merged 1 commit intoswiftlang:masterfrom
vermont42:literal-values
Conversation
Member
|
swiftlang/swift-syntax#239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SwiftSyntax PR implements SR-11580, whose goal is to add convenience properties to get
DoubleandIntvalues fromFloatLiteralExprSyntaxandIntegerLiteralExprSyntax, respectively. The SwiftSyntax PR requires certain changes toNode.pyandExprNodes.pyin the main Swift repo. I have been using these changes locally, but SwiftSyntax-PR reviewer @ahoppen recommended that I create this PR to the main Swift repo for the purpose of CI testing.