Skip to content

Protocol superclass constraints part 4#17851

Merged
slavapestov merged 6 commits intoswiftlang:masterfrom
slavapestov:protocol-superclass-part-4
Jul 10, 2018
Merged

Protocol superclass constraints part 4#17851
slavapestov merged 6 commits intoswiftlang:masterfrom
slavapestov:protocol-superclass-part-4

Conversation

@slavapestov
Copy link
Copy Markdown
Contributor

@slavapestov slavapestov commented Jul 10, 2018 •
edited
Loading

Fixes rdar://problem/38077232 / https://bugs.swift.org/browse/SR-5581, and rdar://problem/34812895 / https://bugs.swift.org/browse/SR-6000.

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please test source compatibility

@slavapestov slavapestov force-pushed the protocol-superclass-part-4 branch from 4ef160f to d70419e Compare July 10, 2018 04:48
@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please test source compatibility

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@aciidb0mb3r Any ideas?

00:33:32 Failing Tests (6):
00:33:32     swift-package-tests :: swift-build-self-host.py
00:33:32     swift-package-tests :: swift-build.txt
00:33:32     swift-package-tests :: swift-package-with-spaces.txt
00:33:32     swift-package-tests :: test-complex-xctest-package/test-xctest-package.txt
00:33:32     swift-package-tests :: test-foundation-package/test-foundation-package.txt
00:33:32     swift-package-tests :: test-xctest-package/test-xctest-package.txt

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test Linux

@slavapestov
Add more tests for protocols with superclass
3937732
@slavapestov
Sema: @objc protocols cannot have a superclass constraint
323b70c
@slavapestov
Sema: Remove dead code from checkInheritanceClause()
bc45bbd
@slavapestov
IRGen: Tweak dynamic casting for protocols with superclasses
01a27ed
@slavapestov
IRGen: Rename addSuperClass() => addSuperclass() for consistency
e3ff63a
@slavapestov
Sema: Ban protocol where clauses that place constraints on 'Self'
eeb5c95 
These will never work properly because of phase ordering issues with
the current declaration checker design. Since we can always express
the same thing with the protocol inheritance clause instead, just
diagnose this as an error instead of trying to hack around it.

Fixes <rdar://problem/38077232>, <https://bugs.swift.org/browse/SR-5581>.
@slavapestov slavapestov force-pushed the protocol-superclass-part-4 branch from d70419e to eeb5c95 Compare July 10, 2018 07:34
@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test

2 similar comments
@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please test source compatibility

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test macOS

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please test source compatibility

@aciidgh
Copy link
Copy Markdown
Contributor

aciidgh commented Jul 10, 2018

@slavapestov sorry about that, I’ll fix them first thing in the morning.

@aciidgh
Copy link
Copy Markdown
Contributor

aciidgh commented Jul 10, 2018

Disabled the tests in swiftlang/swift-integration-tests@a39ef35

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

@swift-ci Please smoke test Linux

@slavapestov
Copy link
Copy Markdown
Contributor Author

slavapestov commented Jul 10, 2018

The source compat suite is broken right now. I'll keep an eye on the bots after merging this.

@slavapestov slavapestov merged commit c45a10b into swiftlang:master Jul 10, 2018
@tsolomko tsolomko mentioned this pull request Apr 18, 2020
Closed
This was referenced Jul 10, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slavapestov @aciidgh