Fixed a number of problems with the fault tolerance calculation when configured with regions #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was 2 and satellites are configured.
…ing a failover and also if the cluster cannot recruit tlogs in the remote region
yangliu1333
approved these changes
Oct 1, 2020
fdbserver/Status.actor.cpp
Outdated
| std::max(maxFaultTolerance, tLogs[i].tLogReplicationFactor - 1 - tLogs[i].tLogWriteAntiQuorum - failedLogs); | ||
|
|
||
| if (tLogs[i].isLocal) { | ||
| // The log generation's fault tolerance is the maximum tlog fault tolerance of each region. |
There was a problem hiding this comment.
this commit seems outdated now, please remove it.
fdbserver/Status.actor.cpp
Outdated
|
|
||
| int maxFaultTolerance = 0; | ||
| int minFaultTolerance = 1000; | ||
| int localSetsWithPositiveFaultTolerance = 0; |
There was a problem hiding this comment.
localSetsWithNonNegativeFaultTolerance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.