Properly handle endpoint failures on the client for all request types #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilure for all request types
Contributor
Author
|
This closes #351 |
ajbeamon
reviewed
May 10, 2018
Contributor
ajbeamon
left a comment
There was a problem hiding this comment.
It looks like each of the usages here is following a similar pattern that might be able to be extracted out (with the exception of warmRanges). My preference would be to do that extraction, which would both be cleaner and also help to avoid a similar mistake if we add a new request to the storage server.
Otherwise, this change seems good.
ajbeamon
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.