Skip to content

Fix unit test failure due to trace event names #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Apr 21, 2019
Merged

Fix unit test failure due to trace event names #1474

jzhou77 merged 1 commit into from
Apr 21, 2019

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Apr 20, 2019 •
edited
Loading

Capitalize the first letter.

Saw errors like:

    <StdErrOutput Output="Trace event detail Type `pairsfilled' is invalid" Severity="40"/>
    <StdErrOutput Output="Trace event detail name `str' is invalid in:" Severity="40"/>
    <StdErrOutput Output="	&quot;Severity&quot;=&quot;10&quot;, &quot;Time&quot;=&quot;26.743637&quot;, &quot;Type&quot;=&quot;TestTraceLineNoDebug&quot;, &quot;Machine&quot;=&quot;[abcd::3:4:3:3]:1&quot;, " Severity="40"/>
    <StdErrOutput Output="Trace event detail name `pair' is invalid in:" Severity="40"/>
    <StdErrOutput Output="	&quot;Severity&quot;=&quot;10&quot;, &quot;Time&quot;=&quot;26.743637&quot;, &quot;Type&quot;=&quot;TestTraceLineNoDebug&quot;, &quot;Machine&quot;=&quot;[abcd::3:4:3:3]:1&quot;, " Severity="40"/>
    <StdErrOutput Output="Trace event detail name `str' is invalid in:" Severity="40"/>
    <StdErrOutput Output="	&quot;Severity&quot;=&quot;10&quot;, &quot;Time&quot;=&quot;26.743637&quot;, &quot;Type&quot;=&quot;TestTraceLineNoDebug&quot;, &quot;Machine&quot;=&quot;[abcd::3:4:3:3]:1&quot;, " Severity="40"/>
    <StdErrOutput Output="Trace event detail name `pair' is invalid in:" Severity="40"/>
    <StdErrOutput Output="	&quot;Severity&quot;=&quot;10&quot;, &quot;Time&quot;=&quot;26.743637&quot;, &quot;Type&quot;=&quot;TestTraceLineNoDebug&quot;, &quot;Machine&quot;=&quot;[abcd::3:4:3:3]:1&quot;, " Severity="40"/>
    <StdErrOutput Output="Trace event detail name `str' is invalid in:" Severity="40"/>
    <ExitCode Code="139" Severity="40"/>

@jzhou77 jzhou77 requested a review from mpilman April 20, 2019 17:22
@xumengpanda
Copy link
Contributor

xumengpanda commented Apr 21, 2019

Interesting, how could this kind of mistake pass the correctness test and sneak in?

mpilman
mpilman approved these changes Apr 21, 2019
View reviewed changes
Copy link
Contributor

@mpilman mpilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpilman
Copy link
Contributor

mpilman commented Apr 21, 2019

Interesting, how could this kind of mistake pass the correctness test and sneak in?

I think the problem here is that we only execute one random unit test with each run. However, I am almost certain that I ran this particular test manually before making a PR - so I am not sure how this happened.

@xumengpanda
Copy link
Contributor

xumengpanda commented Apr 21, 2019

Interesting, how could this kind of mistake pass the correctness test and sneak in?

I think the problem here is that we only execute one random unit test with each run. However, I am almost certain that I ran this particular test manually before making a PR - so I am not sure how this happened.

The change was introduced in the commit c9ee7f54e on 2019-03-15.
We also run a lot of random tests every day. That's why I'm surprised.

@jzhou77 jzhou77 merged commit 05c1924 into apple:master Apr 21, 2019
@jzhou77 jzhou77 deleted the fix-traceevent branch April 21, 2019 17:37
@jzhou77
Copy link
Contributor Author

jzhou77 commented Apr 22, 2019

I think our CI was running on 6.1 branch and not testing the master branch. That's why this wasn't detected earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpilman mpilman mpilman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jzhou77 @xumengpanda @mpilman