not create new symbol with immutable shape convolution.#1867
Merged
YifanShenSZ merged 1 commit intoapple:mainfrom May 31, 2023
Merged
not create new symbol with immutable shape convolution.#1867YifanShenSZ merged 1 commit intoapple:mainfrom
YifanShenSZ merged 1 commit intoapple:mainfrom
Conversation
Collaborator
|
Looks perfect, thanks for the fix! Kicked off CI, will approve once it turns green. |
YifanShenSZ
approved these changes
May 30, 2023
Collaborator
YifanShenSZ
left a comment
There was a problem hiding this comment.
CI passed, approved, thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #1763
If conv uses custom_pad and
pad[r] - effective_ks[r] == -1 and strides[r] == 1, output_shape equals input_shape.In this case we should not create new symbol for shape.
I confirmed flexible MultiHeadAttention works with this change.