fix: self.command_executor instance in _update_command_executor#940
Merged
fix: self.command_executor instance in _update_command_executor#940
Conversation
| # Override command executor | ||
| self.command_executor = RemoteConnection(executor, keep_alive=keep_alive) | ||
| # Override command executor. | ||
| if isinstance(self.command_executor, AppiumConnection): # type: ignore |
Contributor
There was a problem hiding this comment.
why should we ignore mypy here?
Member
Author
There was a problem hiding this comment.
I need to take a look later as a separate PR (to minimize each file change). For now, the below error kept rising without ignore. Maybe it needs a couple of lines' update with type hints.
appium/webdriver/webdriver.py:300: error: Cannot determine type of "command_executor" [has-type]
Contributor
There was a problem hiding this comment.
this looks like a mypy bug.
A similar issue has been reported here: python/mypy#13700
Lets keep it like that for now
mykola-mokhnach
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new replaced instance was always
RemoteConnection, which was not Appium's one. Use AppiumConnection if the executor was already made by AppiumConnection