Conversation
KazuCocoa
commented
Mar 28, 2023
| init_args_for_pool_manager = {'retries': urllib3.util.retry.Retry(total=3, connect=3, read=False)} | ||
| custom_appium_connection = CustomAppiumConnection( | ||
| # keep alive has different route to set init args for the pool manager | ||
| keep_alive=True, |
Member
Author
There was a problem hiding this comment.
Noticed the old method did not work when keep_alive was enabled, so modified to pass the arguments as the init
README.md
Outdated
| appium_executor = AppiumConnection(remote_server_addr='http://127.0.0.1:4723', | ||
| init_args_for_pool_manage=init_args_for_pool_manage) | ||
|
|
||
| options = XCUITestOptions().load_capabilities({ |
Contributor
There was a problem hiding this comment.
load_capabilities was created rather for compatibility with older stuff. Consider using appropriate setters and getters instead
| ): | ||
|
|
||
| # Need to call before super().__init__ in order to pass arguments for the pool manager in the super. | ||
| if init_args_for_pool_manager is None: |
Contributor
There was a problem hiding this comment.
could be simplified to self._init_args_for_pool_manager = init_args_for_pool_manager or {}
mykola-mokhnach
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got a request to use the given executor if the first argument was the instance as same as Selenium does.
Example usage is in the README.