fix: set_value and set_text sent incorrect data#831
Merged
KazuCocoa merged 1 commit intoappium:masterfrom Feb 21, 2023
Merged
Conversation
|
|
Contributor
What is the actual error you get from the server? |
Contributor
Author
Thanks for the quick reply, highly appreciated! |
Contributor
Author
|
CLA should be fixed now. |
Contributor
|
I think you could just add |
5db66bd to
57fb835
Compare
Contributor
Author
|
That sadly does not seem to be possible EDIT: I tried it with the following patch From 5db66bd9e9bd747ff2a4802eec1552bc2154a64e Mon Sep 17 00:00:00 2001
From: eyJhb <eyjhbb@gmail.com>
Date: Fri, 17 Feb 2023 08:30:27 +0100
Subject: [PATCH] fix: set_value and set_text sent incorrect data
---
appium/webdriver/webdriver.py | 1 +
appium/webdriver/webelement.py | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/appium/webdriver/webdriver.py b/appium/webdriver/webdriver.py
index 2866b9e9..430ab17b 100644
--- a/appium/webdriver/webdriver.py
+++ b/appium/webdriver/webdriver.py
@@ -445,6 +445,7 @@ def set_value(self: T, element: MobileWebElement, value: str) -> T:
data = {
'id': element.id,
'value': [value],
+ 'text': value,
}
self.execute(Command.SET_IMMEDIATE_VALUE, data)
return self
diff --git a/appium/webdriver/webelement.py b/appium/webdriver/webelement.py
index 128ceb0c..a8133d5a 100644
--- a/appium/webdriver/webelement.py
+++ b/appium/webdriver/webelement.py
@@ -170,7 +170,7 @@ def set_text(self, keys: str = '') -> 'WebElement':
Returns:
`appium.webdriver.webelement.WebElement`
"""
- data = {'id': self._id, 'value': [keys]}
+ data = {'id': self._id, 'value': [keys], 'text': keys}
self._execute(Command.REPLACE_KEYS, data)
return self
@@ -198,8 +198,9 @@ def set_value(self, value: str) -> 'WebElement':
`appium.webdriver.webelement.WebElement`
"""
data = {
'id': self.id,
'value': [value],
+ 'text': value,
}
self._execute(Command.SET_IMMEDIATE_VALUE, data)
return self |
Contributor
|
@eyJhb could also also provide the full server log for your patch. This seems weird to me as the validation algorithm looks fine to me: |
Contributor
Author
|
Keep in mind, there are the two methods
EDIT: I hope this was what was meant by the logs for the request. Is there anything more that I should send? |
Contributor
|
ah, now I see which endpoint is used. Both endpoints were deprecated and they are not recommended for use anymore: I think the current change is ok, however both APIs should be marked as deprecated. |
Contributor
Author
|
Which endpoint should be used instead? Also, what is the best way to indicate the deprecation? I am unsure of the best formatting, based on the other deprecation I can see. warnings.warn(
'The "launchApp" API is deprecated and will be removed in future versions. '
'See https://github.com/appium/python-client/pull/831',
DeprecationWarning,
)Or what link would make sense? |
Contributor
|
yes the warning above makes sense. Also the deprecation must be mentioned in the docstring. regarding what to use instead - just a regular send_keys. Internally xcuitest driver still redirects to the same POST /value call: |
Contributor
Author
|
Should be fixed not, unsure about the deprecated version, so I've just put the current one :) |
mykola-mokhnach
approved these changes
Feb 20, 2023
Contributor
Author
|
I am unsure how the unit tests should be fixed :) |
Contributor
I think it would probably make sense to remove this test for good as we don't really need to verify deprecated entries |
Member
should be assert d['text'] == value
|
Contributor
Author
Should be fixed now :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_textandset_valuewould not work, without these changes, on the latest beta56 of Appium.These are the values that Appium corrected me with, that I have replaced in the code.
Is there any place where one would validate the parameters that should be sent? Either some documentation, or a reference library?
EDIT: is this the reference to use? https://w3c.github.io/webdriver/#element-send-keys