Skip to content

ci: remove travis2#581

Merged
ki4070ma merged 4 commits intoappium:masterfrom
ki4070ma:rm-travis
Feb 10, 2021
Merged

ci: remove travis2#581
ki4070ma merged 4 commits intoappium:masterfrom
ki4070ma:rm-travis

Conversation

@ki4070ma
Copy link
Copy Markdown
Collaborator

@ki4070ma ki4070ma commented Feb 8, 2021

Makefile Outdated
.PHONY: unittest
unittest: ## Run unittest
python -m pytest test/unit/
python -m pytest ${ARGS} test/unit/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ARGS or @{ARGS} ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least it can be $ARGS (not sure @{ARGS}), but will use $(ARGS) as well as others in this script.

python.version: '3.8'
Python39:
python.version: '3.9'
maxParallel: 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we limit the amount of parallel tasks?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copy-pasted one remains, so I can remove.

@ki4070ma ki4070ma marked this pull request as ready for review February 8, 2021 16:11
@ki4070ma ki4070ma requested a review from KazuCocoa February 8, 2021 16:11
# https://docs.microsoft.com/azure/devops/pipelines/languages/xcode
jobs:
- template: ./ci-jobs/functional_test.yml
- job: 'unitTests' # TODO Decide how to handle tox
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we no longer need tox stuff?
I did some ways in #565 like checking out scripts from their repository or adding related things in this repository. But all of them failed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we no longer need tox stuff?

In my opinion for now, it's unnecessary for ci, but it's useful for running py37-39 in local env.
(current tox usage doesn't match with azure-pipeline since just tox includes running unit test in py37-39, as you know.)

When we look into sample for details, we might be able to use tox in azure pipeline as well.

https://github.com/tox-dev/azure-pipelines-template

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should tweak something more to use the template.
I tried it before, but Azure had an error 856a82f
(I forgot the exact error message, but maybe it was not able to get the template stuff)

Then, it would be nice to address only the local environment about tox in README.
https://github.com/appium/python-client#run-tests

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll try it while this PR is on hold.

@ki4070ma ki4070ma added the WIP label Feb 9, 2021
@ki4070ma ki4070ma removed the WIP label Feb 9, 2021
- task: UsePythonVersion@0
displayName: 'Use Python $(python.version)'
inputs:
versionSpec: '$(python.version)'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nice.
When I did this matrix style, I got no matched python error. But it seems fixed on Azure side(?)

@ki4070ma ki4070ma merged commit 1bf0553 into appium:master Feb 10, 2021
@ki4070ma ki4070ma deleted the rm-travis branch February 10, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants