test: cleanup functional tests and move to unit test to CI stable#1024
Merged
test: cleanup functional tests and move to unit test to CI stable#1024
Conversation
KazuCocoa
commented
Sep 23, 2024
Comment on lines
+24
to
+25
| def set_capability(self: T, name: str, value: Any) -> T: | ||
| ... |
Member
Author
There was a problem hiding this comment.
These are by https://github.com/appium/python-client/blob/master/.pre-commit-config.yaml
Let's see how CI will be...
Member
Author
|
Hm, maybe we should update the commit hook config. Moving to draft for now. |
KazuCocoa
commented
Sep 24, 2024
| httpretty.register_uri(httpretty.POST, appium_command('/session/1234567890/execute/sync'), body='{"value": ""}') | ||
| result = driver.install_app('path/to/app') | ||
|
|
||
| assert {'app': 'path/to/app'}, get_httpretty_request_body(httpretty.last_request()) |
Member
Author
There was a problem hiding this comment.
Like this test's assertion was wrong. I'm fixing this kind of error as well as part of https://github.com/appium/python-client/issues
test/unit/webdriver/context_test.py
Outdated
|
|
||
| driver.switch_to.context('NATIVE_APP') | ||
|
|
||
| assert {'name': 'NATIVE_APP'}, get_httpretty_request_body(httpretty.last_request()) |
Contributor
There was a problem hiding this comment.
assertion is wrong. I think you missed ==
test/unit/webdriver/context_test.py
Outdated
|
|
||
| driver.switch_to.context(None) | ||
|
|
||
| assert {'name': None}, get_httpretty_request_body(httpretty.last_request()) |
Contributor
There was a problem hiding this comment.
mykola-mokhnach
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1023 . It looks like... the amount of change (including test fixes) will gain, so let me split PRs.