chore: Fix functional keyboard tests with appium v1.21.0-beta.0 (#574)

ki4070ma · web-flow · commit 70048fc7c504 · 2021-01-31T20:57:34.000+09:00
* Fix function keyboard tests

* Updated class name for keyboard
diff --git a/ci-jobs/functional_test.yml b/ci-jobs/functional_test.yml
@@ -2,7 +2,7 @@ parameters:
   vmImage: 'macOS-10.15'
   pytestOpt: '--doctest-modules --junitxml=junit/test-results.xml --cov=com --cov-report=xml --cov-report=html'
   androidSdkVer: 27
-  xcodeForIOS: 11.6
+  xcodeForIOS: 12.3
   CI: true
 
 jobs:
diff --git a/test/functional/ios/helper/desired_capabilities.py b/test/functional/ios/helper/desired_capabilities.py
@@ -28,7 +28,7 @@ def get_desired_capabilities(app: Optional[str] = None) -> Dict[str, Any]:
     desired_caps: Dict[str, Any] = {
         'deviceName': iphone_device_name(),
         'platformName': 'iOS',
-        'platformVersion': '13.6',
+        'platformVersion': '14.3',
         'automationName': 'XCUITest',
         'allowTouchIdEnroll': True,
         'wdaLocalPort': wda_port(),
diff --git a/test/functional/ios/keyboard_tests.py b/test/functional/ios/keyboard_tests.py
@@ -13,9 +13,16 @@
 # limitations under the License.
 
 from time import sleep
+from typing import TYPE_CHECKING
+
+import pytest
+from selenium.common.exceptions import NoSuchElementException
 
 from test.functional.ios.helper.test_helper import BaseTestCase
 
+if TYPE_CHECKING:
+    from appium.webdriver.webelement import WebElement
+
 
 class TestKeyboard(BaseTestCase):
     def test_hide_keyboard(self) -> None:
@@ -25,12 +32,12 @@ def test_hide_keyboard(self) -> None:
         el.click()
         el.set_value('Testing')
 
-        el = self.driver.find_element_by_class_name('UIAKeyboard')
-        assert el.is_displayed()
+        assert self._get_keyboard_el().is_displayed()
 
         self.driver.hide_keyboard(key_name='Done')
 
-        assert not el.is_displayed()
+        with pytest.raises(NoSuchElementException):
+            self._get_keyboard_el()
 
     def test_hide_keyboard_presskey_strategy(self) -> None:
         self._move_to_textbox()
@@ -39,12 +46,12 @@ def test_hide_keyboard_presskey_strategy(self) -> None:
         el.click()
         el.set_value('Testing')
 
-        el = self.driver.find_element_by_class_name('UIAKeyboard')
-        assert el.is_displayed()
+        assert self._get_keyboard_el().is_displayed()
 
         self.driver.hide_keyboard(strategy='pressKey', key='Done')
 
-        assert not el.is_displayed()
+        with pytest.raises(NoSuchElementException):
+            self._get_keyboard_el()
 
     def test_hide_keyboard_no_key_name(self) -> None:
         self._move_to_textbox()
@@ -53,14 +60,12 @@ def test_hide_keyboard_no_key_name(self) -> None:
         el.click()
         el.set_value('Testing')
 
-        el = self.driver.find_element_by_class_name('UIAKeyboard')
-        assert el.is_displayed()
+        assert self._get_keyboard_el().is_displayed()
 
         self.driver.hide_keyboard()
-        sleep(10)
 
-        # currently fails.
-        assert not el.is_displayed()
+        with pytest.raises(NoSuchElementException):
+            self._get_keyboard_el()
 
     def test_is_keyboard_shown(self) -> None:
         self._move_to_textbox()
@@ -70,6 +75,9 @@ def test_is_keyboard_shown(self) -> None:
         el.set_value('Testing')
         assert self.driver.is_keyboard_shown()
 
+    def _get_keyboard_el(self) -> 'WebElement':
+        return self.driver.find_element_by_class_name('XCUIElementTypeKeyboard')
+
     def _move_to_textbox(self) -> None:
         el1 = self.driver.find_element_by_accessibility_id('Sliders')
         el2 = self.driver.find_element_by_accessibility_id('Buttons')
