Skip to content

feat: Added optional speed parameter to properly mock locations for android devices#563

Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom
salabogdan:master
Mar 6, 2021
Merged

feat: Added optional speed parameter to properly mock locations for android devices#563
mykola-mokhnach merged 3 commits intoappium:masterfrom
salabogdan:master

Conversation

@salabogdan
Copy link
Copy Markdown
Contributor

Enable applications that use location speed to mock properly mock locations from inside a test.
This is related to:

@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Please sign the CLA

@salabogdan
Copy link
Copy Markdown
Contributor Author

Please sign the CLA

Done.
Screenshot 2021-03-05 at 20 43 07

@salabogdan salabogdan changed the title feat!: Added optonal speed parameter to properly mock locations for a… feat!: Added optional speed parameter to properly mock locations for a… Mar 5, 2021
@salabogdan salabogdan changed the title feat!: Added optional speed parameter to properly mock locations for a… feat: Added optional speed parameter to properly mock locations for a… Mar 5, 2021
@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Please bump the minimum version of io.appium.settings module in package.json to 3.3.0

@salabogdan
Copy link
Copy Markdown
Contributor Author

salabogdan commented Mar 5, 2021

I don't know where to change since i checked package.json and there is no reference to io.appium.settings
The only reference to io.appium.settings that i found was in appium-android-driver/package.json
"io.appium.settings": "^3.1.0" so this should be fine since it uses the latest version?

@salabogdan salabogdan changed the title feat: Added optional speed parameter to properly mock locations for a… feat: Added optional speed parameter to properly mock locations for android devices Mar 5, 2021
@KazuCocoa
Copy link
Copy Markdown
Member

Yes, you should update the point in package.json.
It means this library could use settings version 3.1.0, but your change requires 3.3.0

@salabogdan
Copy link
Copy Markdown
Contributor Author

Did a new pull request here -> appium/appium-android-driver#681 to bump the version to 3.3.0

@mykola-mokhnach mykola-mokhnach merged commit 3b92997 into appium:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants