Skip to content

feat: bump minimum node version to 12, npm 6.9#15000

Merged
mykola-mokhnach merged 3 commits intomasterfrom
bump-node12
Feb 12, 2021
Merged

feat: bump minimum node version to 12, npm 6.9#15000
mykola-mokhnach merged 3 commits intomasterfrom
bump-node12

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

Proposed changes

Node v10 will be EOL in April. It's a good time to bump our mini version as well.
https://nodejs.org/en/download/releases/

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@mykola-mokhnach
Copy link
Copy Markdown
Collaborator

Should we mention this somewhere in docs/README?

- task: NodeTool@0
inputs:
versionSpec: '10.x'
versionSpec: '12.x'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either is fine, 12 or 14

@mykola-mokhnach mykola-mokhnach changed the title feat: bump mim node version to 12, npm 6.9 feat: bump minimum node version to 12, npm 6.9 Jan 7, 2021
@mykola-mokhnach mykola-mokhnach merged commit ef966aa into master Feb 12, 2021
@mykola-mokhnach mykola-mokhnach deleted the bump-node12 branch February 12, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants