Skip to content

Make Upgrade Prepare Message less Error-like#688

Merged
ravenc-appgate merged 2 commits intomainfrom
no-upgrade-message-improve
Aug 7, 2025
Merged

Make Upgrade Prepare Message less Error-like#688
ravenc-appgate merged 2 commits intomainfrom
no-upgrade-message-improve

Conversation

@ravenc-appgate
Copy link
Contributor

Make the message less error-like when the version provided is greater than or equal to the provided version.

@ravenc-appgate ravenc-appgate changed the title Make message less error-like Make Upgrade Perpare Message less Error-like Aug 5, 2025
@ravenc-appgate ravenc-appgate changed the title Make Upgrade Perpare Message less Error-like Make Upgrade Prepare Message less Error-like Aug 5, 2025
@torgermiller
Copy link
Contributor

Do you think it'd be straightforward to have this not show as an error at all but rather a "notice" or something?

Seems like they want customers to not see "error" at all when hitting this as it prompts them to open support cases.

@ravenc-appgate
Copy link
Contributor Author

Do you think it'd be straightforward to have this not show as an error at all but rather a "notice" or something?

Seems like they want customers to not see "error" at all when hitting this as it prompts them to open support cases.

That's what this PR is. This is what the message looks like now.
image

@torgermiller
Copy link
Contributor

Do you think it'd be straightforward to have this not show as an error at all but rather a "notice" or something?
Seems like they want customers to not see "error" at all when hitting this as it prompts them to open support cases.

That's what this PR is. This is what the message looks like now. image

Nice looks good!

@ravenc-appgate ravenc-appgate merged commit edb490b into main Aug 7, 2025
5 checks passed
@ravenc-appgate ravenc-appgate deleted the no-upgrade-message-improve branch August 7, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants