Fix nil pointer exception when using a local file#678
Merged
torgermiller merged 1 commit intomainfrom Jun 30, 2025
Merged
Conversation
a540cdd to
e6bfe7f
Compare
mandopaloooza
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of my remote log bundle support change I introduced a nil pointer exception when using a local file. This PR fixes that by mirroring an error check used in the HTTPS case (the parsedURL will not be nil if the error is nil).
The nil pointer exception occurred because I assumed the parsedURL object would be populated but this is not the case when a filename is used as the parsing fails.