Apply backup password character restrictions#677
Merged
torgermiller merged 2 commits intomainfrom Jul 22, 2025
Merged
Conversation
ccaec5f to
86755f8
Compare
86755f8 to
e567c51
Compare
ravenc-appgate
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we allowed any unicode input for the backup password phrase. This resulted in some weird corners cases when you used certain exotic characters. For simplicity this PR restricts allowed phrases to alphanumeric characters and the following special characters: !@#$%^&*()_+-=[]{}|;':",./<>?~$