Merged
Conversation
Collaborator
There was a problem hiding this comment.
Missing usage for --logserver-bundle?
❯ go run main.go appliance upgrade prepare -h
...
Flags:
--actual-hostname string If the actual hostname is different from that which you are connecting to the appliance admin API, this flag can be used for setting the actual hostname
--dev-keyring Use the development keyring to verify the upgrade image
--docker-registry string Custom docker registry for downloading function docker images. Needs to be accessible by the sdpctl host machine.
--force Force prepare of upgrade on appliances even though the version uploaded is the same or lower than the version already running on the appliance
-h, --help help for prepare
--host-on-controller Use the primary Controller as image host when uploading from remote source
--image string Upgrade image file or URL
--logserver-bundle string Path to a local LogServer image bundle file to upload and use when upgrading a LogServer appliance.
--no-interactive Suppress interactive prompt with auto accept
--skip-container-bundle skip the bundling of the docker images for functions that need them, e.g. the LogServer
--throttle int Upgrade is done in batches using a throttle value. You can control the throttle using this flag (default 5)
Global Flags:
--api-version int Peer API version override
--ci-mode Log to stderr instead of file and disable progress-bars
--debug Enable debug logging
--descending Change the direction of sort order when using the '--order-by' flag. Using this will reverse the sort order for all keywords specified in the '--order-by' flag.
--events-path string send logs to unix domain socket path
-e, --exclude stringToString Filter appliances using a comma separated list of key-value pairs. Regex syntax is used for matching strings. Example: '--exclude name=controller,site=<site-id> etc.'.
Available keywords to filter on are: name, id, tags|tag, version, hostname|host, active|activated, site|site-id, function (default [])
-i, --include stringToString Include appliances. Adheres to the same syntax and key-value pairs as '--exclude' (default [])
--no-verify Don't verify TLS on for the given command, overriding settings from config file
--order-by strings Order appliance lists by keywords, i.e. 'name', 'id' etc. Accepts a comma separated list of keywords, where first mentioned has priority. Applies to the 'appliance list' and 'appliance stats' commands. (default [name])
-p, --profile string Profile configuration to use
-t, --timeout duration Timeout for the upgrade operation. The timeout applies to each appliance which is being operated on (default 30m0s)
Contributor
Author
Good point that does need an update. Just pushed a fix. |
Co-authored-by: Masaya Ando <masaya.ando@appgate.com>
mandopaloooza
approved these changes
Jun 27, 2025
Collaborator
mandopaloooza
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing comments so quickly 😃
Contributor
Author
Sure thing. Appreciate the insightful feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds remote log bundle support.
When the user specifies a log bundle as an http path the file is downloaded to a local temp file and that local temp file is used to complete the upgrade prepare.
Example use:
./sdpctl appliance upgrade prepare --image=~/Downloads/appgate/Appgate-SDP-6.5.0.img.zip --logserver-bundle=http://127.0.0.1:8080/logserver-6.5.image.zip