Skip to content

Translate additional information from old status endpoint#668

Merged
mandopaloooza merged 1 commit intomainfrom
fix-status-translation
May 29, 2025
Merged

Translate additional information from old status endpoint#668
mandopaloooza merged 1 commit intomainfrom
fix-status-translation

Conversation

@mandopaloooza
Copy link
Collaborator

@mandopaloooza mandopaloooza commented May 29, 2025

We found another null pointer on upgrade-complete

[2025-05-29T14:56:25+09:00] Initializing upgrade:
 [COMPLETE] verifying states: ready
[2025-05-29T14:56:25+09:00] Upgrading the primary Controller:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x1687d7c]
goroutine 1 [running]:
github.com/appgate/sdpctl/cmd/appliance/upgrade.upgradeCompleteRun.func3({_, _}, {0xc00034a140, {0xc0000a22a0, 0x11}, 0xc00034a150, 0xc000216648, 0xc000216660, {0x22498e0, 0x0, ...}, ...})
        github.com/appgate/sdpctl/cmd/appliance/upgrade/complete.go:330 +0x2fc
github.com/appgate/sdpctl/cmd/appliance/upgrade.upgradeCompleteRun(0xc000155808, {0x22498e0, 0x0, 0x0}, 0xc000226500)
        github.com/appgate/sdpctl/cmd/appliance/upgrade/complete.go:393 +0x2063
github.com/appgate/sdpctl/cmd/appliance/upgrade.NewUpgradeCompleteCmd.func2(0xc000155808, {0x22498e0, 0x0, 0x0})
        github.com/appgate/sdpctl/cmd/appliance/upgrade/complete.go:105 +0xa9
github.com/spf13/cobra.(*Command).execute(0xc000155808, {0x22498e0, 0x0, 0x0})
        github.com/spf13/cobra@v1.9.1/command.go:1015 +0xa94
github.com/spf13/cobra.(*Command).ExecuteC(0xc000154008)
        github.com/spf13/cobra@v1.9.1/command.go:1148 +0x40c
github.com/appgate/sdpctl/pkg/cmdutil.ExecuteCommand(0xc00020a380?)
        github.com/appgate/sdpctl/pkg/cmdutil/execute.go:44 +0x1f
github.com/appgate/sdpctl/cmd.Execute()
        github.com/appgate/sdpctl/cmd/root.go:255 +0x1a7
main.main()
        ./main.go:10 +0x13

We were not translating the following parameters from old status to new status endpoint:

  • status.Details.Version
  • status.Details.VolumeNumber
  • status.Details.Memory
  • status.Details.Disk
  • status.Details.Status
  • status.Details.Upgrade

The stacktrace shows that we were trying to get the status.Details.VolumeNumber

@github-actions github-actions bot added the bug Something isn't working label May 29, 2025
@mandopaloooza
Copy link
Collaborator Author

mandopaloooza commented May 29, 2025 •
edited
Loading

I performed a number of test

6.1 -> 6.3

[2025-05-29T10:03:13-04:00] Initializing upgrade:
 ✓ verifying states: ready

[2025-05-29T10:03:13-04:00] Upgrading the primary Controller:
 ✓ controller-e9393d6f-dcb9-4b11-8e41-1345290a5f18-site1: upgraded

[2025-05-29T10:07:57-04:00] Upgrading additional appliances (Batch 1 / 1):
 ✓ gateway-e9393d6f-dcb9-4b11-8e41-1345290a5f18-site1: upgraded
2025-05-29T10:09:53-04:00

UPGRADE COMPLETE

Appliance                                                Current Version
---------                                                ---------------
controller-e9393d6f-dcb9-4b11-8e41-1345290a5f18-site1    6.3.10+41653
gateway-e9393d6f-dcb9-4b11-8e41-1345290a5f18-site1       6.3.10+41653

6.1 -> 6.3 (with offline gateway)

Appliances that will be skipped:
  - gateway-d7e51def-e6d9-46b3-8771-09451ad5fd4b-site1: appliance is offline
Do you want to continue? (y/N): y

[2025-05-29T09:54:51-04:00] Initializing upgrade:
 ✓ verifying states: ready

[2025-05-29T09:54:51-04:00] Upgrading the primary Controller:
 ✓ controller-d7e51def-e6d9-46b3-8771-09451ad5fd4b-site1: upgraded
2025-05-29T09:59:46-04:00

UPGRADE COMPLETE

Appliance                                                Current Version
---------                                                ---------------
controller-d7e51def-e6d9-46b3-8771-09451ad5fd4b-site1    6.3.10+41653
gateway-d7e51def-e6d9-46b3-8771-09451ad5fd4b-site1

WARNING: Upgrade was completed, but not all appliances are running the same version.

damara-appgate
damara-appgate approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@damara-appgate damara-appgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mandopaloooza mandopaloooza merged commit cfddf09 into main May 29, 2025
4 checks passed
@mandopaloooza mandopaloooza deleted the fix-status-translation branch May 29, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torgermiller torgermiller torgermiller approved these changes

@damara-appgate damara-appgate damara-appgate approved these changes

@hydrolucid hydrolucid Awaiting requested review from hydrolucid

@ravenc-appgate ravenc-appgate Awaiting requested review from ravenc-appgate

Assignees

No one assigned

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mandopaloooza @torgermiller @damara-appgate