[SA-0] Admin API is not needed in 'sdpctl appliance function download'#662
Merged
mandopaloooza merged 1 commit intomainfrom May 6, 2025
Merged
[SA-0] Admin API is not needed in 'sdpctl appliance function download'#662mandopaloooza merged 1 commit intomainfrom
mandopaloooza merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
ravenc-appgate
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdpctl appliance function downloadis an utility command to download a Function (e.g. LogServer) as a downloadable artifact. These artifacts are used for offline upgrades for some customers that have dark sites (i.e. no internet connection) to download the logserver container image.This endpoint only requires a network connection to the registry to pull the logserver container image as a tarball - it doesn't need authentication to the Admin API. I removed the logic to figure out the image tag from the appliance connection and made
versiona required flag. I also removed the context.BaseAuthContext as it does not require a connection to an appliance to use this command.