Skip to content

Add @generated comment to generated files#1748

Merged
JakeDawkins merged 2 commits intoapollographql:masterfrom
slonoed:master
Feb 6, 2020
Merged

Add @generated comment to generated files#1748
JakeDawkins merged 2 commits intoapollographql:masterfrom
slonoed:master

Conversation

@slonoed
Copy link
Copy Markdown
Contributor

@slonoed slonoed commented Jan 8, 2020

Fixes #1727

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins
Copy link
Copy Markdown
Contributor

Sorry this has slipped my radar! Can you rebase (update) the branch? I'll merge it :)

@slonoed slonoed force-pushed the master branch 5 times, most recently from d032965 to 0f464a9 Compare February 5, 2020 20:47
@slonoed
Copy link
Copy Markdown
Contributor Author

slonoed commented Feb 5, 2020

@JakeDawkins hi! I rebased a diff. However, the build step "Build CLI" is falling. I don't see anything related to my changes. Other PRs also failing with a similar issue.

@JakeDawkins
Copy link
Copy Markdown
Contributor

Thanks @slonoed! Yeah, that one test is failing everywhere right now, so no worries about it :)

@JakeDawkins JakeDawkins merged commit 1dfd737 into apollographql:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[codegen] add @generated pragma to generated files

5 participants