fix: assign roles to owner instead of operator by Lin-1997 · Pull Request #5191 · apolloconfig/apollo

Lin-1997 · 2024-08-01T09:12:54Z

What's the purpose of this PR

when creating an application, assign roles to owner instead of operator

Which issue(s) this PR fixes:

Fixes #5181

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Read the Contributing Guide before making this pull request.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit tests to verify the code.
Run mvn clean test to make sure this pull request doesn't break anything.
Update the CHANGES log.

Summary by CodeRabbit

New Features
- Enhanced role assignment logic to ensure that application roles are accurately assigned to the application's owner instead of a hardcoded user. This improves user access management and security within the application.

Signed-off-by: Lin-1997 <1204878199@qq.com>

coderabbitai · 2024-08-01T09:13:01Z

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes enhance role assignment logic in the application creation process, ensuring that roles like "MODIFY_NAMESPACE" and "RELEASE_NAMESPACE" are accurately assigned to the application's owner rather than a default operator. This refinement addresses issues with improper permission granting when an application is created, leading to a more precise and secure role management system.

Changes

Files	Change Summary
`apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/spi/defaultimpl/DefaultRoleInitializationService.java`	Updated role assignment logic in `initAppRoles` to utilize `app.getOwnerName()` instead of hardcoded operator, enhancing accuracy of permissions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant RoleService

    User->>Application: Create Application (Owner: B)
    Application->>RoleService: Assign Roles (Owner: B)
    RoleService-->>Application: Assign "MODIFY_NAMESPACE" and "RELEASE_NAMESPACE" to B
    Application-->>User: Confirm Role Assignment

Assessment against linked issues

Objective	Addressed	Explanation
A user's permissions are correctly assigned (#5181)	✅
Roles assigned to the actual application owner	✅

Poem

In the fields where rabbits play,
Permissions now align the way.
Owners bask in rightful glow,
Roles assigned, the limits grow.
Hopping high with joy and cheer,
Accurate roles, the vision’s clear! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-08-01T09:13:11Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 49bd8cc and a42aeff.

Files selected for processing (1)

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/spi/defaultimpl/DefaultRoleInitializationService.java (1 hunks)

Additional comments not posted (2)

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/spi/defaultimpl/DefaultRoleInitializationService.java (2)

86-86: LGTM! Role assignment now uses the application's owner.

The change correctly assigns the MODIFY_NAMESPACE role to the application's owner.

89-89: LGTM! Role assignment now uses the application's owner.

The change correctly assigns the RELEASE_NAMESPACE role to the application's owner.

Lin-1997 · 2024-08-01T09:20:27Z

I have read the CLA Document and I hereby sign the CLA

nobodyiam

LGTM

fix: assign roles to owner instead of operator

a42aeff

Signed-off-by: Lin-1997 <1204878199@qq.com>

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 1, 2024

Lin-1997 mentioned this pull request Aug 1, 2024

新建应用时权限赋予错误 #5181

Closed

3 tasks

coderabbitai bot reviewed Aug 1, 2024

View reviewed changes

nobodyiam approved these changes Aug 3, 2024

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 3, 2024

nobodyiam merged commit 8f716ac into apolloconfig:master Aug 3, 2024

github-actions bot locked and limited conversation to collaborators Aug 3, 2024

Lin-1997 deleted the Lin-1997-patch-1 branch August 5, 2024 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: assign roles to owner instead of operator#5191

fix: assign roles to owner instead of operator#5191
nobodyiam merged 1 commit intoapolloconfig:masterfrom
Lin-1997:Lin-1997-patch-1

Lin-1997 commented Aug 1, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 1, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Aug 1, 2024 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Lin-1997 commented Aug 1, 2024

Uh oh!

nobodyiam left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Lin-1997 commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's the purpose of this PR

Which issue(s) this PR fixes:

Brief changelog

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Lin-1997 commented Aug 1, 2024

Uh oh!

nobodyiam left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Lin-1997 commented Aug 1, 2024 •

edited

Loading

coderabbitai bot commented Aug 1, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Aug 1, 2024 •

edited

Loading