refactor(apollo logging): Simplify the default log path to /opt/logs#4833
Merged
nobodyiam merged 97 commits intoapolloconfig:masterfrom Apr 8, 2023
Merged
refactor(apollo logging): Simplify the default log path to /opt/logs#4833nobodyiam merged 97 commits intoapolloconfig:masterfrom
nobodyiam merged 97 commits intoapolloconfig:masterfrom
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4833 +/- ##
============================================
+ Coverage 48.38% 48.40% +0.01%
- Complexity 1722 1724 +2
============================================
Files 346 346
Lines 10827 10827
Branches 1078 1078
============================================
+ Hits 5239 5241 +2
+ Misses 5266 5264 -2
Partials 322 322 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hezhangjian
previously approved these changes
Apr 4, 2023
Member
|
There is an issue that the gc.log would conflict if they are running in one machine. apollo/apollo-configservice/src/main/scripts/startup.sh Lines 95 to 110 in 2800a00 |
Member
|
As I think, we can use a more reasonable name, like /opt/apollo/logs, not magic number |
Contributor
Author
Adding prefix of ServiceName to gc.log path |
nobodyiam
reviewed
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
refactor(apollo logging): Simplify the default log path to
/opt/logsmotivation
The default log path for all Apollo services is prefixed with 100003172, which seems to have no additional purpose but hinders quick locating of log files. It's time to remove it.