Correct the test semantics of the test case in ItemSetControllerTest#4823
Merged
nobodyiam merged 92 commits intoapolloconfig:masterfrom Apr 1, 2023
Merged
Correct the test semantics of the test case in ItemSetControllerTest#4823nobodyiam merged 92 commits intoapolloconfig:masterfrom
nobodyiam merged 92 commits intoapolloconfig:masterfrom
Conversation
# Conflicts: # README.md
…SetControllerTest
Codecov Report
@@ Coverage Diff @@
## master #4823 +/- ##
============================================
+ Coverage 48.15% 48.24% +0.08%
- Complexity 1719 1721 +2
============================================
Files 346 346
Lines 10777 10777
Branches 1075 1075
============================================
+ Hits 5190 5199 +9
+ Misses 5265 5256 -9
Partials 322 322 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
How about we use restTemplate and add try catch block in the test codes? |
Contributor
Author
Yes, the code has been adjusted |
nobodyiam
reviewed
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Correct the test semantics of the test case in
ItemSetControllerTest.motivation
RestTemplate.noErrorHandlerRestTemplatein other places.