Improve the documentation for the config-service.cache.enabled configuration property.#4810
Improve the documentation for the config-service.cache.enabled configuration property.#4810nobodyiam merged 81 commits intoapolloconfig:masterfrom
Conversation
# Conflicts: # README.md
…ache.enabled configuration property.
Codecov Report
@@ Coverage Diff @@
## master #4810 +/- ##
=========================================
Coverage 47.23% 47.23%
Complexity 1660 1660
=========================================
Files 346 346
Lines 10685 10685
Branches 1065 1065
=========================================
Hits 5047 5047
Misses 5329 5329
Partials 309 309 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It's actually a known issue as is also recorded in the apollo project. There was an attempt to fix this issue #3542 but not continued. I think we could still consider fixing it if there is an easier way. |
|
The worst part is that MySQL was not strictly set to match case sensitivity from the beginning, so now we have to do compatibility processing. I think we can merge this PR first, As for the compatibility processing issue, I will look into it later. |
What's the purpose of this PR
Improve the documentation for the config-service.cache.enabled configuration property.
Motivation
Possible solutions
If we want to enable in-memory caching and ensure that the loading behavior remains consistent with when it is not enabled, could we simply convert the cache key of Guava Cache to lowercase? Would this cause any additional problems? I'm not entirely sure. One thing to consider is that the code already handles namespaces in a similar way, so is this new issue consistent with that?