Fix the issue of the system permission management page retrieving non-existent users.#4802
Merged
nobodyiam merged 79 commits intoapolloconfig:masterfrom Mar 17, 2023
Merged
Fix the issue of the system permission management page retrieving non-existent users.#4802nobodyiam merged 79 commits intoapolloconfig:masterfrom
nobodyiam merged 79 commits intoapolloconfig:masterfrom
Conversation
# Conflicts: # README.md
… page retrieving non-existent users.
Member
|
Please also fix the unit test. |
Codecov Report
@@ Coverage Diff @@
## master #4802 +/- ##
============================================
- Coverage 47.29% 47.24% -0.06%
Complexity 1660 1660
============================================
Files 346 346
Lines 10683 10684 +1
Branches 1063 1064 +1
============================================
- Hits 5053 5048 -5
- Misses 5322 5328 +6
Partials 308 308
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
This pr has two changes as follows.
Trigger scenario description: We switched from the local user system to LDAP. When a user in LDAP is deleted, it is not deleted synchronously. It is expected that there should be no user ID that does not exist in the system. When I try to delete this user ID, the check for the existence of the deleted user is triggered, so this is very contradictory.