Skip to content

feature: A user-friendly config management page for apollo portal#4592

Merged
nobodyiam merged 40 commits intoapolloconfig:masterfrom
webSue:yst01
Oct 20, 2022
Merged

feature: A user-friendly config management page for apollo portal#4592
nobodyiam merged 40 commits intoapolloconfig:masterfrom
webSue:yst01

Conversation

@webSue
Copy link
Copy Markdown
Contributor

@webSue webSue commented Sep 29, 2022 •
edited
Loading

What's the purpose of this PR

开源之夏2022 系统配置管理模块开发

Which issue(s) this PR fixes:

Fixes #
原系统参数页面用户不友好，无法查看所有支持的配置信息等

Brief changelog

新的系统参数页面，支持portalDB中所有配置项的显示，支持编辑功能，若key存在则覆盖，不存在则新增。新增配置按钮+可使用filter过滤查找配置

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 29, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@webSue
Copy link
Copy Markdown
Contributor Author

webSue commented Sep 29, 2022

I have read the CLA Document and I hereby sign the CLA

@webSue webSue changed the title 提交 feature: A user-friendly config management page for apollo portal Sep 29, 2022
@klboke
Copy link
Copy Markdown
Contributor

klboke commented Sep 29, 2022

Need to resolve code conflicts

@mghio
Copy link
Copy Markdown
Contributor

mghio commented Sep 29, 2022

Please use the apollo code style for format the codes.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2022 •
edited
Loading

Codecov Report

Merging #4592 (3029aad) into master (67030ba) will increase coverage by 0.05%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #4592      +/-   ##
============================================
+ Coverage     46.38%   46.43%   +0.05%     
- Complexity     1563     1565       +2     
============================================
  Files           331      332       +1     
  Lines         10360    10367       +7     
  Branches       1043     1043              
============================================
+ Hits           4805     4814       +9     
  Misses         5259     5259              
+ Partials        296      294       -2
Impacted Files Coverage Δ
...ork/apollo/portal/service/ServerConfigService.java 60.00% <60.00%> (ø)
...ollo/portal/controller/ServerConfigController.java 70.58% <100.00%> (+3.92%) ⬆️
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 56.92% <0.00%> (-1.54%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+14.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

klboke
klboke reviewed Oct 8, 2022
View reviewed changes
Comment thread scripts/sql/delta/v210-v220/apolloportaldb-v210-v220.sql Outdated
Comment thread apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js Outdated
Comment thread ...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java Outdated
Comment thread ...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java Outdated
Comment thread ...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java Outdated
Comment thread apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/api/AdminServiceAPI.java Outdated
Comment thread apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ServerConfigService.java Outdated
klboke
klboke reviewed Oct 8, 2022
View reviewed changes
Comment thread apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ServerConfigService.java Outdated
@nobodyiam nobodyiam mentioned this pull request Oct 9, 2022
Closed
klboke
klboke reviewed Oct 13, 2022
View reviewed changes
Comment thread ...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java Outdated
Comment thread ...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java Outdated
@klboke
Copy link
Copy Markdown
Contributor

klboke commented Oct 14, 2022

功能验收 OK， @nobodyiam 可以帮忙确认下么

@klboke
Copy link
Copy Markdown
Contributor

klboke commented Oct 18, 2022

LGTM

klboke
klboke previously approved these changes Oct 18, 2022
View reviewed changes
nobodyiam
nobodyiam reviewed Oct 19, 2022
View reviewed changes
Comment thread apollo-portal/src/main/resources/static/i18n/en.json Outdated
Comment thread apollo-portal/src/main/resources/static/i18n/en.json Outdated
Comment thread apollo-portal/src/main/resources/static/i18n/zh-CN.json Outdated
Comment thread apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js Outdated
Comment thread apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js Outdated
Comment thread apollo-portal/src/main/resources/static/scripts/services/ServerConfigService.js Outdated
Comment thread apollo-portal/src/main/resources/static/scripts/services/ServerConfigService.js Outdated
@webSue
Copy link
Copy Markdown
Contributor Author

webSue commented Oct 19, 2022

@nobodyiam The code has been modified

nobodyiam
nobodyiam approved these changes Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit f8d35bd into apolloconfig:master Oct 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

@klboke klboke klboke left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@webSue @klboke @mghio @nobodyiam