Upgrade mysql-connector-java version to fix possible transaction rollback failure issue#4425
Merged
klboke merged 33 commits intoapolloconfig:masterfrom Jun 22, 2022
Merged
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4425 +/- ##
============================================
- Coverage 53.41% 53.39% -0.02%
- Complexity 2686 2687 +1
============================================
Files 490 490
Lines 15254 15254
Branches 1586 1586
============================================
- Hits 8148 8145 -3
- Misses 6548 6552 +4
+ Partials 558 557 -1
Continue to review full report at Codecov.
|
Member
|
@nobodyiam |
Contributor
Author
|
I don't know much about the protocol rules, but I see that spring-boot and skywalking also have this dependency, and they are both open source projects for the Apache protocol. So, it shouldn't be a big problem. No other questions then, I'll merge it in first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
There is a known bug in mysql-connector-java:8.0.28 that prevents transaction rollback when useLocalSessionState=true. apollo does not disallow users to set mysql link parameters, so there may be a potential problem
This bug was fixed in mysql-connector-java:8.0.29
Reference: https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/news-8-0-29.html