Fix the npe issue for old version of gray release rules#4382
Merged
Anilople merged 1 commit intoapolloconfig:masterfrom May 27, 2022
Merged
Fix the npe issue for old version of gray release rules#4382Anilople merged 1 commit intoapolloconfig:masterfrom
Anilople merged 1 commit intoapolloconfig:masterfrom
Conversation
19a742e to
d9ff4c8
Compare
d9ff4c8 to
9a282d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4382 +/- ##
============================================
- Coverage 53.19% 53.19% -0.01%
Complexity 2674 2674
============================================
Files 489 489
Lines 15275 15277 +2
Branches 1580 1580
============================================
+ Hits 8125 8126 +1
- Misses 6595 6600 +5
+ Partials 555 551 -4
Continue to review full report at Codecov.
|
kezhenxu94
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Fix the npe issue for old version of gray release rules, e.g.
[{"clientAppId":"appidA","clientIpList":["127.0.0.1"]}].Which issue(s) this PR fixes:
Fixes #4380
Brief changelog
clientIpListandclientLabelListwill be initialized to empty set.Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.