Skip to content

upgrade spring boot to 2.6.6 and spring cloud to 2021.0.1#4295

Merged
lepdou merged 1 commit intoapolloconfig:masterfrom
nobodyiam:upgrade-spring-boot-266
Apr 4, 2022
Merged

upgrade spring boot to 2.6.6 and spring cloud to 2021.0.1#4295
lepdou merged 1 commit intoapolloconfig:masterfrom
nobodyiam:upgrade-spring-boot-266

Conversation

@nobodyiam
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam commented Apr 2, 2022

What's the purpose of this PR

upgrade spring boot to 2.6.6 and spring cloud to 2021.0.1

Which issue(s) this PR fixes:

Fixes #4282

Brief changelog

  • upgrade spring boot to 2.6.6
  • spring cloud to 2021.0.1
  • set spring.jpa.defer-datasource-initialization to true for tests
  • fix mockito deprecated classes

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested review from a team April 2, 2022 11:56
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2022 •
edited
Loading

Codecov Report

Merging #4295 (499d325) into master (039801a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4295      +/-   ##
============================================
- Coverage     53.15%   53.13%   -0.02%     
+ Complexity     2668     2667       -1     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
- Hits           8107     8105       -2     
- Misses         6591     6592       +1     
- Partials        555      556       +1
Impacted Files Coverage Δ
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <0.00%> (-5.41%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039801a...499d325. Read the comment docs.

@nobodyiam nobodyiam added this to the 2.0.0 milestone Apr 3, 2022
@nobodyiam nobodyiam force-pushed the upgrade-spring-boot-266 branch from 4f52492 to b9191b2 Compare April 3, 2022 07:08
Anilople
Anilople reviewed Apr 3, 2022
View reviewed changes
Comment thread apollo-client/src/test/java/com/ctrip/framework/apollo/internals/AbstractConfigTest.java Outdated
@nobodyiam nobodyiam force-pushed the upgrade-spring-boot-266 branch from b9191b2 to 8c0cb25 Compare April 3, 2022 12:13
@nobodyiam nobodyiam force-pushed the upgrade-spring-boot-266 branch from 8c0cb25 to 499d325 Compare April 3, 2022 12:15
@nobodyiam nobodyiam requested review from a team and Anilople April 3, 2022 12:16
lepdou
lepdou approved these changes Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lepdou lepdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lepdou lepdou merged commit db6a439 into apolloconfig:master Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
@nobodyiam nobodyiam deleted the upgrade-spring-boot-266 branch April 5, 2022 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lepdou lepdou lepdou approved these changes

@Anilople Anilople Awaiting requested review from Anilople

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Upgrade Spring Boot to 2.6.x

4 participants

@nobodyiam @codecov-commenter @lepdou @Anilople