Skip to content

test(apollo-core): PropertiesUtilTest#4113

Merged
Anilople merged 13 commits intoapolloconfig:masterfrom
youyulan:my-version1
Nov 27, 2021
Merged

test(apollo-core): PropertiesUtilTest#4113
Anilople merged 13 commits intoapolloconfig:masterfrom
youyulan:my-version1

Conversation

@youyulan
Copy link
Copy Markdown
Contributor

@youyulan youyulan commented Nov 23, 2021

What's the purpose of this PR

I write a test file for \apollo-core\src\main\java\com\ctrip\framework\apollo\core\utils\PropertiesUtils.java

Which issue(s) this PR fixes:

Fixes #3874

Brief changelog

write two test method for the two function in PropertiesUtils.java seperately.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 23, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@youyulan
Copy link
Copy Markdown
Contributor Author

youyulan commented Nov 23, 2021

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 24, 2021 •
edited
Loading

Codecov Report

Merging #4113 (d5286d6) into master (80a33ab) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4113      +/-   ##
============================================
+ Coverage     52.49%   52.55%   +0.05%     
- Complexity     2614     2616       +2     
============================================
  Files           484      484              
  Lines         15206    15206              
  Branches       1572     1572              
============================================
+ Hits           7983     7992       +9     
+ Misses         6671     6660      -11     
- Partials        552      554       +2
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
...ip/framework/apollo/core/utils/PropertiesUtil.java 76.92% <0.00%> (+76.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a33ab...d5286d6. Read the comment docs.

Anilople
Anilople requested changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time to participate in open source contributions.

Welcome!

Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated
Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated

@Test
public void TestProperties() throws IOException {
assertTrue("".equals(PropertiesUtil.toString(new Properties())));
Copy link
Copy Markdown
Contributor

@Anilople Anilople Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use assertEqual or assertEquals instead of assertTrue

Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated

Properties properties = new Properties();
properties.put("a","aaa");
assertTrue("a=aaa\r\n".equals(PropertiesUtil.toString(properties))
Copy link
Copy Markdown
Contributor

@Anilople Anilople Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User System.lineSeperator instead of hard code \r\n \n

Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated

@Test
public void TestFilterComment(){
StringBuffer sb=new StringBuffer("#aaaaa\nbbb");
Copy link
Copy Markdown
Contributor

@Anilople Anilople Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String.join(System.lineSepeartor, "#aaaaa“, "bbb"); ?

Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated
}

@Test
public void TestFilterComment(){
Copy link
Copy Markdown
Contributor

@Anilople Anilople Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void TestFilterComment(){
public void testFilterPropertiesComment(){

Keep the method name's convention of test case.

Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated
@Test
public void TestFilterComment(){
StringBuffer sb=new StringBuffer("#aaaaa\nbbb");
PropertiesUtil.filterPropertiesComment(sb);
Copy link
Copy Markdown
Contributor

@Anilople Anilople Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add more test case to cover all conditional branchs

apollo/apollo-core/src/main/java/com/ctrip/framework/apollo/core/utils/PropertiesUtil.java

Lines 46 to 57 in 9e19898

static boolean filterPropertiesComment(StringBuffer stringBuffer) {
//check whether has comment in the first line
if (stringBuffer.charAt(0) != '#') {
return false;
}
int commentLineIndex = stringBuffer.indexOf("\n");
if (commentLineIndex == -1) {
return false;
}
stringBuffer.delete(0, commentLineIndex + 1);
return true;
}

zouyx
zouyx reviewed Nov 26, 2021
View reviewed changes
Comment thread apollo-core/src/test/java/com/ctrip/framework/apollo/core/utils/PropertiesUtilTest.java Outdated
import java.util.Properties;

/**
* @author Wu Mingkan(Dalian University of Technology)
Copy link
Copy Markdown
Member

@zouyx zouyx Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete author in community project.

@Anilople Anilople changed the title A PR for PropertiesTest.java test(apollo-core): PropertiesUtilTest Nov 27, 2021
Anilople
Anilople approved these changes Nov 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople Anilople merged commit 4a20206 into apolloconfig:master Nov 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
@Anilople Anilople added good first issue good first issue Good for beginners area/test Categorizes issue or PR as related to testing labels Nov 27, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zouyx zouyx zouyx left review comments

@Anilople Anilople Anilople approved these changes

Assignees

No one assigned

Labels

area/test Categorizes issue or PR as related to testing good first issue good first issue Good for beginners

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

test: improve coverage

5 participants

@youyulan @codecov-commenter @zouyx @Anilople @nobodyiam