ConfigFileFormat#Properties are now fully compatible with themselves#4033
Merged
nobodyiam merged 7 commits intoapolloconfig:masterfrom Oct 17, 2021
Merged
Conversation
Previously `ConfigFileFormat#Properties` were not fully compatible by themself which meant the function `ConfigFileFormat.isPropertiesCompatible` was not really meaning full. PropertiesConfigFiles are now designed to be compatible bythemselves by implementing `PropertiesCompatibleConfigFile`. This might be usefull in further development. Currently `DefaultConfigFactory.create` will not create a properties compatible repository since this is not really usefull and a localRepositry might be easier to use in further development.
Codecov Report
@@ Coverage Diff @@
## master #4033 +/- ##
============================================
+ Coverage 51.63% 51.65% +0.01%
- Complexity 2543 2547 +4
============================================
Files 484 484
Lines 14839 14844 +5
Branches 1536 1536
============================================
+ Hits 7662 7667 +5
Misses 6645 6645
Partials 532 532
Continue to review full report at Codecov.
|
nobodyiam
requested changes
Oct 16, 2021
Member
nobodyiam
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Here are some minor comments:
…goKrupitza/apollo into chore/configFileFormat-compatibility
Contributor
Author
|
@nobodyiam everything should be resolved now 👍🏽😌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
ConfigFileFormat#Propertieswere not fully compatible bythemself which meant the function
ConfigFileFormat.isPropertiesCompatiblewas not really meaning full. PropertiesConfigFiles are now designed to be
compatible bythemselves by implementing
PropertiesCompatibleConfigFile.This might be usefull in further development.
Currently
DefaultConfigFactory.createwill not create a propertiescompatible repository since this is not really usefull and a
localRepositry might be easier to use in further development.
What's the purpose of this PR
In PR #4030 we found out that
ConfigFileFormat#Propertiesare not compatible by themselves which might become problematic in the future.Which issue(s) this PR fixes:
None
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.