Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks, please also update the CHANGES.md |
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
=========================================
Coverage 50.10% 50.10%
Complexity 2479 2479
=========================================
Files 485 485
Lines 14996 14996
Branches 1533 1533
=========================================
Hits 7514 7514
Misses 6950 6950
Partials 532 532 Continue to review full report at Codecov.
|
|
@nobodyiam thanks for your reminding, I have updated CHANGES.md. |
|
Thanks, it looks good to me. However, we are now in the middle of releasing 1.9.0, so this bugfix would go to the next version. Let's wait several days and we would create a new CHANGES.md. |
JaredTan95
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution.
admin/config/portal 三个模块的启动脚本中查找 SERVICE_NAME-*.jar 的逻辑中,判断文件是否存在时没有正确读取 shell 变量,需要添加 $ 符号到 shell 变量左边。