This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Conversation
kylef
reviewed
Jun 18, 2019
| bool hasEqualMembers(const Object& lhs, const Object& rhs) | ||
| { | ||
| using itemType = typename Object::container_type::const_reference; | ||
| for (itemType item : lhs.data) { |
Member
There was a problem hiding this comment.
If I understand this logic correctly, if there is the following I think they'll be treated as equal.
LHS:
+ name: doe
RHS:
+ name: doe
+ additional: true
Since the logic loops over lhs members and verifies they are equal to rhs. Additional RHS members are ignored.
Perhaps a guard that the length of lhs and rhs are equal at the top of the function would solve this problem?
Contributor
Author
There was a problem hiding this comment.
There is on upper level checked count of members is equal.
https://github.com/apiaryio/drafter/pull/714/files#diff-c71b7d4a5846e44057ccc118bacbe934R59
So situation you describe should not happen. But if you like I can make it in one step.
kylef
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #664