chore: ignore JUnit and @types/node major bumps in Dependabot#98
Merged
Conversation
- org.junit.jupiter:junit-jupiter — JUnit 6 requires Java 17+, but the build targets <release>8</release>. Ignoring major until the Java baseline is bumped. - @types/node — should track the Node LTS declared in engines.node rather than chasing the current Node major line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents Dependabot from re-opening two major-version bumps that don't fit the project's current constraints:
org.junit.jupiter:junit-jupiter— JUnit 6 requires Java 17+, butjvm/pom.xmlpins<release>8</release>. PR chore(deps-dev): bump org.junit.jupiter:junit-jupiter from 5.12.2 to 6.0.3 in /jvm #93 failed CI for exactly this reason. Ignore scope: majors only; minor/patch bumps continue to flow.@types/node— should track the Node LTS declared inengines.node(currently 22), not the current Node major line. Type-only PRs like chore(deps-dev): bump @types/node from 22.19.17 to 25.6.0 in /npm #94 pass CI because types erase at runtime, but semantically the type surface should match the runtime we target.Both ignore rules are scoped to
version-update:semver-major. Security advisories would still open PRs regardless.Test plan