feat: add createLexerAndParser helper for unified error listening#87
Merged
Conversation
Adds a new ApexParserFactory.createLexerAndParser(source, listener) helper in both the TS and Java packages. It attaches the required ApexErrorListener to both the lexer and the parser so a single listener instance captures lexer-level errors (e.g. invalid string escapes) as well as parser errors. The TS ApexErrorListener base class generic is widened to `Token | number` so one listener can be attached to both recognizers. Closes #83
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
nawforce
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApexParserFactory.createLexerAndParser(source, listener)to both the TS and Java packages. The listener is required and wired to both the lexer and the parser, so a singleApexErrorListenerinstance captures lexer-level errors (e.g. invalid string escapes) alongside parser errors.ApexErrorListenerbase class generic toToken | numberso one listener instance can be attached to both recognizers.Closes #83
Test plan
mvn test(jvm) — 73 tests passnpm test(npm) — 74 tests passnpx prettier --checkandnpx eslinton changed files — clean