feat: add CJS and browser builds via Rollup#109
Merged
kjonescertinia merged 2 commits intoMay 12, 2026
Conversation
The npm package previously shipped ESM-only. This adds CJS (for require() consumers) and browser (ESM + UMD with antlr4 inlined) outputs using Rollup with esbuild transpilation. Type declarations are generated separately with .d.ts and .d.cts for both module systems. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kjonescertinia
approved these changes
May 12, 2026
|
I came to add this when I noticed the beta release included it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require()the package; browser consumers get a self-contained bundle with antlr4 inlined.d.tsand.d.ctsfor full TypeScript resolution in all module systemsTest plan
import { ApexParserFactory } from './dist/esm/index.js'require('./dist/cjs/index.cjs')npx publintandnpx arethetypeswrong --pack .for export map validation<script type="module">🤖 Generated with Claude Code