[WIP] Introduce the general client conf for mr/spark #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could u help check this proposal for mr/spark client conf? This POC only does the basic implementation. If this is OK, I will go ahead. @jerqi |
Contributor
|
The proposal is OK for me. |
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
============================================
- Coverage 58.41% 58.04% -0.38%
+ Complexity 1273 1272 -1
============================================
Files 158 160 +2
Lines 8448 8497 +49
Branches 784 787 +3
============================================
- Hits 4935 4932 -3
- Misses 3260 3311 +51
- Partials 253 254 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok? |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal.
What changes were proposed in this pull request?
Introduce the general client conf for mr/spark
RssClientConfto set the general configOptions for mr/sparkRssSparkClientConfto set the spark exclusiveconfigOptionsand to construct the RssConf from theSparkConfRssMRClientConfWhy are the changes needed?
Now in mr/spark client conf, we don't obey the rule of uniffle
configOptions. It causes the some problems as followsRssSparkConfig/RssClientConfig/RssMRConfig. Actually there is no need to leave dirty works for developers.Does this PR introduce any user-facing change?
No
How was this patch tested?
UTs.