Skip to content

Conversation

@lifeSo
Copy link
Collaborator

@lifeSo lifeSo commented Dec 24, 2023

What changes were proposed in this pull request?

Add a integration test case for Spark with MiniYarnCluster

Why are the changes needed?

Fix: #138

Does this PR introduce any user-facing change?

No.

How was this patch tested?

It self is test case

@lifeSo lifeSo changed the title [128] Improvement: Add a integration test case for Spark with MiniYarnCluster [128] [Improvement]: Add a integration test case for Spark with MiniYarnCluster Dec 24, 2023
@lifeSo lifeSo changed the title [128] [Improvement]: Add a integration test case for Spark with MiniYarnCluster [128] improvement: Add a integration test case for Spark with MiniYarnCluster Dec 24, 2023
@lifeSo lifeSo changed the title [128] improvement: Add a integration test case for Spark with MiniYarnCluster [128] improvement: Add a integration test case for Spark with MiniYarnCluster —— in test state Dec 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecbf2e7) 53.22% compared to head (e8746ec) 54.14%.
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1395      +/-   ##
============================================
+ Coverage     53.22%   54.14%   +0.91%     
- Complexity     2715     2719       +4     
============================================
  Files           418      399      -19     
  Lines         23932    21605    -2327     
  Branches       2043     2042       -1     
============================================
- Hits          12738    11698    -1040     
+ Misses        10408     9190    -1218     
+ Partials        786      717      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston
Copy link
Member

zuston commented Dec 25, 2023

The PR title should obey the rule like that [#128] improvement(tests): Add a integration test case for Spark with MiniYarnCluster

And If this is on progress, you can mark this PR as draft that could be finished by this button,
image

@lifeSo lifeSo marked this pull request as draft December 25, 2023 16:56
@lifeSo lifeSo changed the title [128] improvement: Add a integration test case for Spark with MiniYarnCluster —— in test state [#128] improvement: Add a integration test case for Spark with MiniYarnCluster —— in test state Dec 27, 2023
@lifeSo lifeSo changed the title [#128] improvement: Add a integration test case for Spark with MiniYarnCluster —— in test state [#128] improvement: add a integration test case for Spark with MiniYarnCluster Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Add a integration test case for Spark with MiniYarnCluster

3 participants