[#460] improvement: Exit on OutOfMemoryError #1390
Conversation
bin/start-shuffle-server.sh
Outdated
| -XX:+PrintGCTimeStamps \ | ||
| -XX:+CrashOnOutOfMemoryError \ | ||
| -XX:+ExitOnOutOfMemoryError \ | ||
| ${OOM_DUMP_OPTS} \ |
There was a problem hiding this comment.
I think we can just use JAVA_OPTS, because users may need add more options.
There was a problem hiding this comment.
It all ok, but I think there is "MAX_DIRECT_MEMORY_OPTS", so I added OOM_DUMP_OPTS.
There was a problem hiding this comment.
I mean we can add a env variable like spark.driver.extraJavaOptions which in spark. So that users can add any arguments to JVM_ARGS by just add arguments to JAVA_OPTS .
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1390 +/- ##
============================================
+ Coverage 53.22% 54.11% +0.89%
- Complexity 2715 2720 +5
============================================
Files 418 399 -19
Lines 23932 21628 -2304
Branches 2043 2050 +7
============================================
- Hits 12738 11705 -1033
+ Misses 10408 9205 -1203
+ Partials 786 718 -68 ☔ View full report in Codecov by Sentry. |
| -XX:+PrintGCTimeStamps \ | ||
| -XX:+CrashOnOutOfMemoryError \ | ||
| -XX:+ExitOnOutOfMemoryError \ | ||
| -XX:+PrintTenuringDistribution \ |
There was a problem hiding this comment.
We use this args in PRD, so PTAL.
jerqi
left a comment
There was a problem hiding this comment.
LGTM. thanks @lifeSo @zuston @xianjingfeng
What changes were proposed in this pull request?
Exit on OutOfMemoryError
Why are the changes needed?
Fix: #460
Does this PR introduce any user-facing change?
No.
How was this patch tested?