Skip to content

Conversation

@zivali
Copy link
Contributor

@zivali zivali commented Nov 5, 2023

What changes were proposed in this pull request?

  • Modify client_guide.md to include only shared configurations
  • Add three subpages to it for 3 different clients: spark, mapreduce, and tez

Why are the changes needed?

Fix: #1094

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Modifying documentation only.

Additional Notes

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits.

Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop.
Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce.
Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez.
Uniffle has provided pluggable client plugins to enable remote shuffle in Spark, MapReduce, and Tez.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MapReduce, -> MapReduce?


Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop.
Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce.
Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache Hadoop, -> Apache Hadoop?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zivali , merged to master.

@jerqi jerqi merged commit 59e08e5 into apache:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Split the client.md into four documents

2 participants