-
Notifications
You must be signed in to change notification settings - Fork 168
[#1094] docs: split client_guide.md #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jerqi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits.
docs/client_guide/client_guide.md
Outdated
| Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop. | ||
| Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce. | ||
| Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez. | ||
| Uniffle has provided pluggable client plugins to enable remote shuffle in Spark, MapReduce, and Tez. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MapReduce, -> MapReduce?
docs/client_guide/client_guide.md
Outdated
|
|
||
| Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop. | ||
| Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce. | ||
| Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache Hadoop, -> Apache Hadoop?
jerqi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zivali , merged to master.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #1094
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modifying documentation only.
Additional Notes