[#1096] chore(ci): add kubernetes integration test to the pipeline #1113
Conversation
| - name: Compile kubernetes operator | ||
| run: | | ||
| mvn package -Pkubernetes -DskipTests | ||
| - name: Run local Integration Tests |
There was a problem hiding this comment.
These steps are also needed.
- name: Checkout project
uses: actions/checkout@v3
- name: Set up JDK ${{ inputs.java-version }}
uses: actions/setup-java@v3
with:
java-version: ${{ inputs.java-version }}
distribution: ${{ inputs.jdk-distro }}
- name: Cache local Maven repository
if: ${{ inputs.cache-key != '' }}
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-
- name: Set up Go ${{ inputs.go-version }}
if: ${{ inputs.go-version != '' }}
uses: actions/setup-go@v3
with:
go-version: ${{ inputs.go-version }}
If kubernetes module code isn't changed, the kubernetes ci won't be triggered. So you can add a empty line in the file https://github.com/apache/incubator-uniffle/blob/master/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go to trigger kubernetes CI.
There was a problem hiding this comment.
My fault. If we add empty line, k8s ci will fail because of code style. So I add a blank in the comment. Now, we can run the k8s ci.
There was a problem hiding this comment.
There still are some other errors. Could you fix them?
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
============================================
- Coverage 54.08% 53.71% -0.38%
- Complexity 2542 2574 +32
============================================
Files 386 391 +5
Lines 21882 22314 +432
Branches 1811 1867 +56
============================================
+ Hits 11835 11986 +151
- Misses 9351 9622 +271
- Partials 696 706 +10 see 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| - name: Execute `mvn ${{ inputs.maven-args }}` | ||
| run: mvn -B -fae ${{ inputs.maven-args }} | tee /tmp/maven.log | ||
| shell: bash | ||
| shell: bash |
There was a problem hiding this comment.
Please revert unrelated changes.
| shell: bash | |
| shell: bash |
| //+kubebuilder:object:root=true | ||
|
|
||
| // RemoteShuffleServiceList contains a list of RemoteShuffleService | ||
| // RemoteShuffleServiceList contains a list of RemoteShuffleService |
There was a problem hiding this comment.
Please revert unrelated changes.
| // RemoteShuffleServiceList contains a list of RemoteShuffleService | |
| // RemoteShuffleServiceList contains a list of RemoteShuffleService |
There was a problem hiding this comment.
This change will trigger k8s ci. So we shouldn't revert before we verify the correctness of k8s integration pipeline.
|
I have'nt made changes to any tests but the pipeline is failing at that step. |
It's irrelevant error. You can ignore it. |
| mvn package -Pkubernetes -DskipTests | ||
| - name: Run local Integration Tests | ||
| run: | | ||
| cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh |
There was a problem hiding this comment.
There is a bash error. I will fix the issue of the bash.
Let me use the command and I will merge this pr first.
cd deploy/kubernetes/integration-test/e2e && echo "execute e2e tests"
And then I will fix the script later.
There was a problem hiding this comment.
@jerqi can we merge this ?
What changes were proposed in this pull request?
Added kubernetes Integration test CI to parallel.yaml
Why are the changes needed?
Add kubernetes Integration test CI
Fix: #1096
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: