Improve the TSMgmtUpdateRegister with an optional file name #10642
Conversation
b024286 to
a24f9ec
Compare
10f26ad to
b8bd566
Compare
shukitchan
left a comment
There was a problem hiding this comment.
Let's update documentation as well - https://docs.trafficserver.apache.org/en/latest/developer-guide/api/functions/TSMgmtUpdateRegister.en.html
2681761 to
980bed9
Compare
|
[approve ci autest] |
1 similar comment
|
[approve ci autest] |
|
Providing this filename makes the update registry keep track of file changes automatically. When used, the continuation provided will only be called if changes to the configuration file is detected. Also, this eliminates the superflous code for calling a named plugin reload. That code is never used, and I don't like having code there "just because", when nothing uses it.
7abc310 to
4cad488
Compare
Yeh, I can email, but it doesn't break or modify any existing plugins (because we can now provide defaults in API changes).
With # 2, yes, it's useless, but removing it would break compatibility unnecessarily. I'd rather keep it, if not only because it could at least allow for easier debugging later. |
Providing this filename makes the update registry keep track of file changes automatically. When used, the continuation provided will only be called if changes to the configuration file is detected.
Also, this eliminates the superflous code for calling a named plugin reload. That code is never used, and I don't like having code there "just because", when nothing uses it.