This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Missing user in logs bug #7282
Merged
Missing user in logs bug #7282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapAccessLog function
…icious cookie, access_token, and bearer token
Codecov Report
@@ Coverage Diff @@
## master #7282 +/- ##
=========================================
Coverage 26.11% 26.11%
Complexity 98 98
=========================================
Files 648 648
Lines 76057 76080 +23
Branches 90 90
=========================================
+ Hits 19862 19872 +10
- Misses 54362 54373 +11
- Partials 1833 1835 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
reviewed
Jan 12, 2023
…erToken, MojoCookie. Reorged import. Added logging for case where user is not found from cookie.
… unt it test for getCookieToken in wrappers_test.go.
srijeet0406
suggested changes
Jan 24, 2023
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
… with username parsing verification.
srijeet0406
reviewed
Jan 26, 2023
traffic_ops/traffic_ops_golang/routing/middleware/wrappers_test.go
Outdated
Show resolved
Hide resolved
srijeet0406
approved these changes
Jan 27, 2023
Contributor
srijeet0406
left a comment
There was a problem hiding this comment.
Code looks great! All automated tests pass.
Manual verification passed as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix logs user when requests are made to Traffic_Ops when different authentication methods are used.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
To test this change, you will need to test an API call to TO using 3 different authentication methods(mojolicious, access token, and bearer token).
mojolicious cookie" -H "Content-Type: application/json" "your TO endpoint"access token" -H "Content-Type: application/json" "your TO endpoint"access token" -H "Content-Type: application/json" "your TO endpoint"If this is a bugfix, which Traffic Control versions contained the bug?
Master
PR submission checklist