Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Nov 14, 2022

We need to roll back Rascal changes until we can identify all the tools that expect Traffic Monitor to be Rascal. Users may have tools used internally that hard-code RASCAL which need to first change before these changes can be merged. So before changing it, we need to have a discussion on the mailing list to ensure everyone's okay with it.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • CDN in a Box
  • Automation

What is the best way to verify this PR?

Run integration, unit test.
Ensure CIAB build correctly
TO API endpoints work as expected.
Clients (eg: T3C) work as expected.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 requested a review from ocket8888 November 14, 2022 18:18
@zrhoffman
Copy link
Member

zrhoffman commented Nov 14, 2022

This PR reverts #7068, #7172, and #7175

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed seem to revert the specified changes. But I don't think it's recorded anywhere: can you explain why this is necessary? Otherwise it seems like a step backwards to anyone not in the know.

@zrhoffman zrhoffman mentioned this pull request Nov 14, 2022
3 tasks
@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops Traffic Monitor related to Traffic Monitor high impact impacts the basic function, deployment, or operation of a CDN labels Nov 16, 2022
@ocket8888 ocket8888 added cdn-in-a-box related to the Docker-based CDN-in-a-Box system cache-config Cache config generation TO Client (Go) related to the Go implementation of a TC client tc-health-client Traffic Control Health Client labels Nov 16, 2022
@ocket8888 ocket8888 self-assigned this Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation cdn-in-a-box related to the Docker-based CDN-in-a-Box system high impact impacts the basic function, deployment, or operation of a CDN tc-health-client Traffic Control Health Client TO Client (Go) related to the Go implementation of a TC client Traffic Monitor related to Traffic Monitor Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants