This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed response code and docs for acme_accounts #6602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcfdev
approved these changes
Mar 3, 2022
Collaborator
tcfdev
left a comment
There was a problem hiding this comment.
Looks good. POST returns 201 Created where PUT returns 200 Ok. Docs reflect the desire.
Contributor
|
Needs conflict resolution before it can be merged |
564d6a2 to
764166e
Compare
Contributor
|
More conflicts cropped up |
764166e to
37b4f00
Compare
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6370
This PR fixes the response code on a PUT to /acme_accounts to use a 200 instead of 201 and updates the docs for a POST to the same endpoint to reflect the 201 returned
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that the docs build and look good
Verify that the response codes are correct and reflected in the documentation
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist