Skip to content

Conversation

@jhorstmann
Copy link
Contributor

In apache/datafusion#14281 it was noticed that the go parquet implementation writes metadata containing boolean lists in an unexpected encoding. The collection type was encoded as 0x02, which the documentation now specifies as an allowed alternative value to 0x01. The values were encoded as 0 (false) and 1 (true), which matches a previous version of the documentation (see documentation update in 2c29c56). This change makes the rust TCompactInputProtocol support both variations.

Happy to create a jira ticket if needed.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@alamb
Copy link

alamb commented Feb 3, 2025

Related ticket in thrift:

@Jens-G Jens-G added the rust label Feb 3, 2025
@Jens-G Jens-G merged commit 717bd79 into apache:master Feb 4, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants